[Bug]:Inventory Scanner Field showed name 'air' in jade
cleep5564 opened this issue ยท 17 comments
Issue description
[Bug]:Inventory Scanner Field showed name 'air' in jade
Steps to reproduce
1.Install jade and security craft
2.Launch the game
3.Place 2 Inventory Scanners to create a field
4.Look at the field
5.See the bug
Minecraft version
1.21.4
Forge/NeoForge version
21.4.89(SecurityCraft version is v1.9.12-beta4,but the latest version in the list is beta1!)
SecurityCraft version
v1.9.12-beta1
Other relevant versions
No response
If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)
No response
@bl4ckscor3 Is it possible to prioritize the items checked by scanner into neighboring inventory blocks?Scanner will process entity in the order of the array,and processes items in the order of their ids in the slot,entity If the blocks and the scanner all are full,it will stop working.
So is the problem with this program flow the rigor of the logic or the efficiency of the operation?
I found another solution: the current scanner has no use for installing storage with zone solidification turned on, and here's a prioritization scheme that might solve the problem
When the scanner has enough storage space for all the items in that solid, remove the solid's counterpart and allow it to pass through
If the scanner is short on space but has room to spare, remove some of the entity's items in order to block passage
If there is no space left, prevent the entity from passing
That's an interesting idea. It will change how the Solidify Field option works at the moment, though, and adds codependency of module and option functionality, which we generally try to avoid.
@bl4ckscor3
Here are two simple solutions:
A:Make the collectible item and redstone detection area slightly larger than the size of the region solidified area
B:Trigger the detection logic on collision with a face on the area solidification
Of course, this assumes that these modules can work when the area solidification is turned on
Explanation: once a storage module can remove a player's item in such a way, the item does not exist in the player's inventory and the area solidification allows the player to pass through it
By the way,I can not connnect to discord,Where else can I submit a suggestion?
We'd like to have suggestions for the mod consolidated on the Discord server so we can more easily manage them. I can make an exception once if you really can't join our Discord, so feel free to post one here on GitHub.
(And thank you for notifying about the missing versions in the template! I fixed that now.)
An inverse selection for the inventory scanner is something we want to add, but have yet to design properly. It comes with a couple challenges that are not straight-forward to solve; One of them being the amount of items to be removed is most likely big, and won't fit into the scanner. Reinforced beds have been denied in the past, as we didn't see much of a benefit of having them over a respawn anchor in a secure room. What we can see however is a bed mine, akin to the already existing block mines.
@bl4ckscor3
I just signed up for a discord account without any previous logins, but the first time I logged in I was prompted to be banned! (All the information I filled in had not been used in a discord registration before) I tried to appeal with the link, but cloudflare kept trying to load for hours but with no results!
Well,I think it would be better to add an inverse selection feature to the inventory scanner,and what about reinforced bed?
Thanks.:)
@bl4ckscor3
Oh, I guess I could submit a pull request with the desired functionality in the blurb, and submit the translated text of the relevant entry with the help of the pr modify file function, killing two birds with one stone!