Security Craft

Security Craft

63M Downloads

Reinforced blocks can be broken by magic mods, and other mods.

KleinByte opened this issue ยท 7 comments

commented

Issue description

Irons spells has a spell called touch dig that is instantly able to delete reinforced blocks.
I'm assuming there are other mods that can do this.

I think the best way around this, is that if the mod is not from securitycraft that breaks or deletes a reinforced block, it should just be instantly placed back.

Steps to reproduce

No response

Minecraft version

1.21.1

Forge/NeoForge version

21.1.151

SecurityCraft version

v1.10

Other relevant versions

No response

If a (crash)log is relevant for this issue, link it here: (It's almost always relevant)

No response

commented

As of commit fb1d9d9, other mods should now see ownable blocks as being unbreakable again. Tested with Create and Irons Spells, both cannot mine ownable blocks anymore after the above commit.

commented

@bl4ckscor3 did u see the code in the duplicate? If u add that u can fix it.

commented

Yes, I did. But I haven't had a chance to look at it properly and also don't know if that's the proper fix.

commented

@bl4ckscor3 It can be used as a fix, but you probably have a bug in your logic to prevent players from destroying other player's reinforced blocks, so the proper way would be to look for that. Normal tools or fist don't work, but the spells do, im not sure how they are different. Their BlockEvent.BreakEvent events still have the player as source included, are you not relying on that for the check? (Im using the code i sent and it works well as a fix). Good luck finding the bug or missing code :)

commented

Unfortunately there's not really a good way to see what mod breaks a block.
Is player 1 able to break blocks placed by player 2 using these means? If so, does setting the "vanilla tool block breaking" config to false change anything about that?

commented

what is the command to enable reinforced blocks? because rn in my server the reinforced block remover is shown to be turned off and we can break it with normal tools

commented

Please do not post unrelated questions on issues. Use our Discord for support.
That said, reinforced blocks are always enabled. A recent change made it possible to break them using normal tools, without changing who can break them. It's still that only the owner can break them, and none other. You can enable previous behavior in the server config.