[🐞]: Moonlight crashes on startup with EveryCompat, Oh The Biomes We've Gone, & MoreBeehiveVariants
MylesGit opened this issue · 11 comments
BEFORE CONTINUING:
- Always check you are using the latest version of these mods and its dependencies
- Remove known problematic rendering mods such as Optifine, Sodium and others
Version-Loader
1.21-FABRIC
Moonlight Lib Version
Moonlight 1.21-2.18.13
Describe the Issue
When EveryCompat calls from Moonlight for things to do with beehives (with a mod that provides different wood installed and MoreBeehiveVariants), it causes a crash. I was told to open an issue here instead of on the EveryCompat repo (#905).
This issue only occurs on versions 1.21-2.10.0 and up of EveryCompat. 1.21-2.9.10 boots with no issues.
It seems someone rewrote the code regarding beehives in Moonlight Lib and it caused some regressions.
Log Attachment
OPTIONAL: To Produce
Install these mods (Not mentioning dependencies):
- Moonlight 1.21-2.18.13
- EveryCompat 1.21-2.10.2
- Friends&Foes 4.0.0
- Oh The Biomes We've Gone 2.3.13
- MoreBeehiveVariants 1.2.1
Boot the game, notice crash.
Failed to add blocks to POI minecraft:beehive. Somehow the set was not mutable?
OPTIONAL: Which mods are affected?
EveryCompat 1.21-2.10.0 and up
ML (moonlight) ML v2.18.13 & EC (everycompat) v2.10.2 fix the problem. I've ran a test on my side. if you still get a crash, then one of the mods is causing the problem. You may want to investigate and find the code.
I'll do a quick test on my side. with just Friends & Foes, EC, ML and Wood mods. I'll try and see if i can reproduce the crash
ML (moonlight) ML v2.18.13 & EC (everycompat) v2.10.2 fix the problem. I've ran a test on my side. if you still get a crash, then one of the mods is causing the problem. You may want to investigate and find the code.
It only crashes when you have a mod that adds more wood types. Make sure you have all the mods listed in the report. All of my mods are up-to-date and this crash is still present.
Also, let me clarify. Moonlight 1.21-2.18.13 & EveryCompat 1.21-2.10.0 fixed the prior issue that I reported in #905, but this is a new issue that was present in that version, but I only noticed after the initial bug got fixed.
I reset the test instance I was using and now I can't recreate the issue... Odd.
Let me see if reinstalling one of the mods fixed the issue. Will update when I make progress.
Alright, I'm stupid. Forgot to put MoreBeehiveVariants in the reproduce list and only put it in the title. That's what a lack of caffeine on a Sunday will do to you.
Make sure to have all those mods installed. If any one of them is disabled the crash wont happen.
The code from Moonlight Lib in EC's Friends & Foes have been disabled for now.
It's still a Work-In-Progress. No solution have been found for POI (Point-Of-Interest) stuff that will make blocks become ACQUIRABLE_JOBS for villagers. Also, the cause for Failed to add blocks to POI minecraft:beehive. Somehow the set was not mutable? haven't discovered yet.