Serene Seasons

Serene Seasons

Mods
53M Downloads

Horizontal Panes Compatibility

HopsandBarley opened this issue · 4 comments

commented

Feature Request

[Horizontal Pane compatibility with Serene Seasons]

What feature are you suggesting?

[ Allow for horizontal panes to be used as roofs for greenhouses, for out-of-season crop farming]

Why should it be added?

[ Allow for more options for greenhouses for builders.
link to horizontal panes: https://www.curseforge.com/minecraft/mc-mods/horizontal-panes-forge ]

image

commented

any update if something like this will be coming?

commented

The best solution would probably be for us to add a block tag, but that would mean other mods would have to add the tag as well. I can do it soon, but IDK when a build will be made with it, since we need to re-setup Serene Season's build server.

commented

Gonna close this now as I added the block tag system, and there's one for greenhouse glass that other modders can add blocks to in their mods (https://github.com/Glitchfiend/SereneSeasons/blob/SS-1.16.x-4.x.x/src/main/resources/data/sereneseasons/tags/blocks/greenhouse_glass.json)

Should hopefully be a build up with all of this soon, whenever Adubbz gets around to fixing our build server.

commented

I'd suggest changing this check (

SereneSeasons/src/main/java/sereneseasons/handler/season/SeasonalCropGrowthHandler.java

Line 101 in a92ba63

if (world.getBlockState(cropPos.offset(0, i + 1, 0)).getBlock() instanceof AbstractGlassBlock)
) so that it checks a block tag. This would allow pack makers (as well as other mod makers) to add and/or remove acceptable blocks.

  • 👍1