Distant Horizons compatibility
pajicadvance opened this issue · 9 comments
What's the issue you encountered?
Serene Seasons and Distant Horizons don't play well with each other at the moment. This is due to LODs from Distant Horizons not reloading on season change (can be trivially implemented by using the DH API in Serene Seasons), and DH not being aware of grass and foliage color changes from Serene Seasons.
How can the issue be reproduced?
- Launch the game with the following mods:
[✔] DistantHorizons-2.2.1-a-1.21.1-neo-fabric
[✔] fabric-api-0.115.0+1.21.1
[✔] GlitchCore-fabric-1.21.1-2.1.0.0
[✔] SereneSeasons-fabric-1.21.1-10.1.0.1 - Set render distance to 8 to see the LODs more easily
- Load into a world and teleport to the nearest birch forest
/locate biome minecraft:birch_forest - Move away from the birch forest far enough that it gets turned into LODs
- Set the season to early winter
/season set early_winter. Observe that the LODs are unaffected since they do not reload on season change
- Exit into the main menu, then load back into the world. Observe that the birch leaves color got updated to match the season, but not the grass or foliage color
Logs
Mod Version
fabric-1.21.1-10.1.0.1
Additional information
The issue where the LODs don't reload on season change can be fixed trivially by using the DH API. Inserting
DhApi.Delayed.renderProxy.clearRenderDataCache();
after the allChanged() call in the section below will cause the LODs to reload on the spot after a season change, without having to exit and load back into the world.
This does not fix the other issue where DH seems to only be aware of the birch leaves color change and not the grass or foliage color changes. The cause of this issue is unknown to me.
It's definitely something I'd personally like to see in the mod considering I'm a big fan of DH myself, but IDK if/when it'll happen since I don't really handle the coding side of things.
+1. If this and snow generation existing after spring if you've not been somewhere, and this, would make this the perfect seasons mod
+1 I'm leaning toward removing seasons because I'm so anal about this issue, but I'm afraid of the effect it will have on my old world, and until I noticed this, I was pretty sure I'd finished this modlist off. I'm sending positive waves
