Serene Seasons

Serene Seasons

69M Downloads

"season get" command outputs current season, but does not "return" it

HatTrkPatrk opened this issue ยท 0 comments

commented

What's the issue you encountered?

When running the /season get command, it of course shows the current season to the player's chat or the server console, but it does not return it; instead, it always returns 1.

This inhibits the ability of datapacks that want to run commands based on the current season. For example:

scoreboard objectives add sereneseasons dummy
execute store result score current_season sereneseasons run season get
execute if score current_season sereneseasons matches 5 run ...

This will be broken because the scoreboard value for current_season will always be set to 1, as returned by the command:

It instead needs to return the value as described in the config file:

	#1 - 3 = Early/Mid/Late Spring
	#4 - 6 = Early/Mid/Late Summer
	#7 - 9 = Early/Mid/Late Autumn
	#10 - 12 = Early/Mid/Late Winter

How can the issue be reproduced?

N/A

Logs

N/A

Mod Version

10.1.0.3

Additional information

No response