Server Country Flags

Server Country Flags

7M Downloads

[Bug] Does not support SRV

Finoway opened this issue ยท 2 comments

commented

Hello,

I realised that the ServerCountryFlags mod doesn't support SRV DNS, so either we have the ip flag in type A or CNAME and if there is no A or CNAME we get a "?".

Example on minehut with the domain minehut.gg which has no type A or CNAME.

Here are the DNS informations for minehut.gg which uses an SRV type:
image
image
image

Here is an example in the list of servers:
image

commented

Hi, thanks for reporting this issue! The mod does resolve SRV DNS, but only if it resolved the hostname from A/CNAME first.
minehut.gg is a special case which has a SRV record and no other records, which I haven't considered.
If the hostname has a SRV record, the mod will ignore what it had resolved previously, so that is definitely a bug.
I will fix this in an upcoming version, thanks!
image

commented

This issue should now be fixed in version 1.7.2, which will be available to download shortly (1.20.x only for now). Thanks!