Missing some files in update
Saereth opened this issue · 8 comments
MC 1.18.2
Version: serverconfigupdater-2.0
Forge: 40.1.80
I'm running into an issue where the serverconfig update is not grabbing all the files that it should.
For example;
["Version Configuration"]
# Define a version here. On world load the mod will look up the serverconfig version and reset all files that specified up to the newest version.
# Example: ["1=minecraft","2=forge"] will reset minecraft and forge config on first load, but will only reset forge if the world has been loaded before with only version 1 defined
versions = ["4=minecraft,forge,curios,create,immersiveengineering,artifacts,carryon,champions,create,evilcraft,extrachampions,minecolonies,productivebees,witherstormmod,constructionwand;"]
This is my config, and as expected it does copy SOME of the files on boot up:
[26Oct2022 13:29:15.658] [Server thread/INFO] [com.darkere.serverconfigupdater.ServerConfigUpdater/]: Resetting configs for: evilcraft, champions, forge, witherstormmod, curios, carryon, create, artifacts, extrachampions, productivebees, minecolonies, immersiveengineering
[26Oct2022 13:29:15.661] [Server thread/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\evilcraft-server.toml
[26Oct2022 13:29:15.662] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\champions-gamestages.toml
[26Oct2022 13:29:15.664] [Server thread/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\forge-server.toml
[26Oct2022 13:29:15.670] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\witherstormmod-server.toml
[26Oct2022 13:29:15.676] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\curios-server.toml
[26Oct2022 13:29:15.679] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\carryon-server.toml
[26Oct2022 13:29:15.687] [Server thread/INFO] [configured/]: Loading server configs...
[26Oct2022 13:29:15.688] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\create-server.toml
[26Oct2022 13:29:15.694] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\artifacts-server.toml
[26Oct2022 13:29:15.702] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\extrachampions-affixes.toml
[26Oct2022 13:29:15.704] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\productivebees-server.toml
[26Oct2022 13:29:15.710] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\minecolonies-server.toml
[26Oct2022 13:29:15.724] [Thread-0/INFO] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Loading default config file from path ftba\instances\11fdca4d-c861-426c-bcce-a87fa13a1299\defaultconfigs\immersiveengineering-server.toml
This is missing MANY of the server configs for champions mod, these are all the configs the chamion mod ads in the serverconfig
So it's only grabbing one of the configs (champions-gamestages.toml in this case) and ignoring all the other champions configs.
Forge does not support having more than one server config. As such it's not possible to detect and regenerate them without specific hacks which I will not implement.
Forge does not support having more than one server config.
Can you elaborate on this? I'm the developer of Champions, looking to resolve this issue either on my end or this end. The multiple server configs noted above as used by Champions seem to all work correctly. I've also tested to see if they can be detected by other mods and all of the config files can be detected in the set returned by ConfigTracker.INSTANCE.configSets().get(ModConfig.Type.SERVER), so it should be possible to detect and regenerate them like any other config file.
private final ConcurrentHashMap<String, Map<ModConfig.Type, ModConfig>> configsByMod;
That Map clearly indicates there should only be one server config per mod.
But... I realize after looking at my code, that I can avoid using that. Will fix this.
