ServerCore

ServerCore

7M Downloads

Crash when holding a map with Impersonate installed

Pyrofab opened this issue ยท 0 comments

commented

Original issue : Ladysnake/Impersonate#26

Game instances with both this mod and Impersonate installed seem to crash when a player has a map in their inventory during impersonation :
crash-2022-07-20_21.40.42-server.txt (tested with Impersonate 2.6.1 and ServerCore 1.3.0-1.19).

Steps to reproduce :

  1. Install ServerCore and Impersonate
  2. Start an impersonation with /impersonate disguise as Pyrofab
  3. Get a map

It looks like this crash is caused by MapItemSavedDataMixin assuming that a player's name always consists of a text literal, which is not the case when Impersonate is installed. This could most easily be fixed by adding an instanceof check before the cast.