ServerSync

ServerSync

48.5k Downloads

Version 2.2 Does not delete removed files.

Junrall opened this issue ยท 14 comments

commented

If I add an updated mod and delete the old one from the server then update the client, the new file is downloaded but the old one is not removed.

commented

Hmm, it seems to be working for me, can you provide more information?

commented

No problem. Here is what I'm running:
ServerSync 2.2
Forge 1407
Java 8
Windows 8.1
MultiMC on my desktop.

Scenario:
AOBD-2.6.3 on the server and AOBD-2.6.2 on the client.
I run ServerSync... it recognizes that there are two different AOBD versions.
AOBD-2.6.3 is downloaded to the client mods folder and ServerSync says that AOBD-2.6.2 has been deleted.
I click YES to restart.

I look in my folder and see that both AOBD-2.6.2 and AOBD-2.6.3 are in the mods folder.
I went ahead and started minecraft again thinking that maybe ServerSync might do something before the other mods are loaded... no go.

Here is the output: http://pastebin.com/FRSQp2FM

commented

So it's not deleting ./mods/AOBD-2.6.2.jar ? is this correct?

(also if you don't mind, please use pastebin)

commented

Yes that is correct. This happens with any mod file that is supposed to be deleted... though, I don't know that this happens with any of the configs.

Sorry about that, I'll re-edit the post and use pastebin.

commented

So, just ran some more tests. Config files are being deleted when they are supposed to. So the problem is only with deleting mod files.
It seems as if ServerSync is unable to delete mod files because they are still in use.

I have also dialed back to Forge 1403 thinking that there might be something different within newer Forge versions. Sadly, the problem still persists.

commented

You are absolutely correct. This is a bug.

And you are correct, it cannot delete the mod because it is in use by java. I am working on a solution.

commented

I just updated but have not changed the version. I am at work so I cannot do testing at the moment. Would you mind testing the new version for me?

https://github.com/superzanti/ServerSync/blob/master/build/libs/serversync-2.2.jar

I still have it labeled 2.2 but I can assure you things have changed.

Get back to me on weather or not this fixes the issue.

commented

Haha, I'm at work as well. I'll test as soon as I'm able to.

commented

Not sure if the bug is fixed as I am receiving an EOF error.
Sorry, I hope you're not pulling your hair out!

Here is the error message: http://pastebin.com/S5xECPG9

commented

Haha not at all. As long as you guys are patient and keep helping me find the bugs it will be fixed soon :)

commented

Well, just in case... I sent you some beer! ๐Ÿบ

commented

Awww! Thank youu!! ๐Ÿ‘

commented

Deleted
Reason: Please refrain from posting the same thing in every issue thread.

commented

@Junrall
I worked real hard tonight and fixed the most recent error.

Now as far as I can tell everything works as it's supposed to except updating a file. Files are deleted and added just fine though.

I'm closing this issue. I started a new issue for the updating.