ServerSync

ServerSync

48.5k Downloads

Client Not Getting Config Modifications

P3rf3ctXZer0 opened this issue · 5 comments

commented

Serversync Version:

serversync-2.6.17.jar

Minecraft Version:

1.12.2

Issue:

not sending updated config files to client when simple changes are made causing changes to not be sent - seems unless file size changes file is unsent. Small changes not detected. Maybe create hash based on bytes?

Solution - Unknown

commented

Interesting, do you have the config file and changes in question.

Trying out a basic text file swapping between 1 & 0 has no issues with hash collision (not that I would really expect it to), though honestly, I have not really looked into the hashing being used in SS yet, it is code left over from before I was on the project.

commented

Digging into this it appears to be using MD5 under the hood, which in theory still has an extremely small chance of hash collision.

Could change to SHA-256.

commented

yeah that seems ideal.

commented

@P3rf3ctXZer0
If you are not comfortable with building ServerSync I have attached a snapshot of the commit that changes to SHA-256. Probably going to wrap up a few of these latest issues before releasing a version publicly.
serversync-snapshot.zip

commented

Alright I will test it good sir 🗡