Enhancement Request: Remove files found on client that are "ignored" in config
syndicate25 opened this issue ยท 7 comments
Serversync Version: 2.6.11
Minecraft Version: 1.7.10
Issue: The mod ignores items listed in the config and does not download them, which is fine... but does not remove them if they are found on the client. Items found on the client that are listed in the ignore section of the config file should be deleted, if found, from the client end.
The ignore list is designed for clients to tell ServerSync to ignore files that they don't want to be deleted when trying to mirror the server.
e.g. You have Optifine installed and you don't want ServerSync to delete it as it is a client only mod.
Sounds like you would like a block list for clients, so you as a client can block servers from sending you particular mods / files?
This would be easy enough to make, though quite easily misused to break the purpose of SS.
"Sounds like you would like a block list for clients, so you as a client can block servers from sending you particular mods / files?"
More or less, yes.
The issue I have is, when new players join my server and sync for the first time, they get EVERYTHING. When they sync again, it doesn't recognize that "oh, those are server only mods... let's get rid of those.", and that's exactly what I'd like it to have the ability to do since clients end up loading an extra unneeded 20 something mods in that situation.
EDIT: I'd like to add that the reason they get everything is because they don't have the config they need for those files to be ignored yet when they sync for the first time. Syncing again after that doesn't remove any unwanted files now that they have the config, either.
(As a side note, I've found that it simply doesn't recognize some files in the list at all, and syncs them whether I have them listed as "do not sync these to the client" or not. I am interested in trying the version you just released when I get home though to see if it solves the problem of it not recognizing some mods in the config. If this still exists, I'll make a new issue for it with examples.)
Or, as you said before, have a folder, much like the clientmods folder, which you can put SERVERside only mods in, which NEVER get synced to ANY client, regardless of a config, thus essentially creating a "block list."
You may be able to achieve the desired result by adding the server only mods to the ignore list in the server config.
This tells the server to ignore the files in question essentially making ServerSync treat them like they don't exist.
-snip-
That comment belongs with the other issue I posted, not in the enhancement request.
The reason I'm requesting such an enhancement is because the biggest problem occurs on the initial sync, when there are NO configuration files on the client itself, so it downloads EVERYTHING. From that point, there's no way to remove the server-side only mods except to manually delete them, which can be tiresome to explain to some people... as I know you understand. Yes, at least on some versions of serversync, I've been able to exclude the server only files when clients sync up. But that's only after the "damage" has already been done.
If you could plop said server-side only mods into a designated folder on the server to permanently exclude them from synchronization, that would be ideal. No need for configuring specific files, no need to walk users through deletion processes....
If this is even a possible option, are there any concerns of exploits with the method I've suggested? Would it be possible to add?
I can add a folder for server specific mods, it is a little funky though as I would need to copy said mods from servermods to mods at some point thereby duplicating files between the two directories.
Could potentially do something with symlinks though I don't know how/if forge handles that.
Seem like the real issue that you are facing is that serversync for whatever reason is not working properly in your environment, the two ignore lists (client/server) should let you achieve what you want.
If I just need to learn to properly set up the configs in the new version, then I will try that and let you know if it still doesn't work. You're saying it's possible for a client with absolutely 0 configuration files, INCLUDING serversync, to not have server-only mods pushed to it on the initial sync?