Close serversync in update time
gollariel opened this issue ยท 5 comments
Serversync Version:
2.6.17
Minecraft Version:
1.12.2 (forge 14.23.5.2768)
Issue:
If client closed window in update time, then we can see a lot of errors in the log (on server)
Logs (serverysync & minecraft)
[11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2958) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1538) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:79) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.lang.Thread.run(Thread.java:748) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: java.io.EOFException [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2958) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1538) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:79) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.lang.Thread.run(Thread.java:748) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: java.io.EOFException [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2958) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1538) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:79) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.lang.Thread.run(Thread.java:748) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: java.io.EOFException [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2958) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1538) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:79) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.lang.Thread.run(Thread.java:748) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: java.io.EOFException [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream$BlockDataInputStream.peekByte(ObjectInputStream.java:2958) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1538) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.io.ObjectInputStream.readObject(ObjectInputStream.java:431) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:79) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [com.superzanti.serversync.ServerWorker:run:90]: at java.lang.Thread.run(Thread.java:748) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: java.lang.OutOfMemoryError: unable to create new native thread [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.Thread.start0(Native Method) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.Thread.start(Thread.java:717) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.Timer.(Timer.java:176) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.util.Timer.(Timer.java:146) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at com.superzanti.serversync.ServerWorker.run(ServerWorker.java:77) [11:28:21] [ClientThread - /46.133.133.86/INFO] [STDERR]: [java.lang.ThreadGroup:uncaughtException:1052]: at java.lang.Thread.run(Thread.java:748)
Indeed, I don't think SS is currently handling the case where a user terminates part way through an update.
Does this actually nuke the server, or is this just console spam with the server still being operable afterward?
Nvm, didn't see the OOM error at the end of the log there.
Definitely not so good.
Could you try using version 2.6.20 of ServerSync.
I am not seeing this issue when closing the client part way through a file download.
Newer SS versions can be found here: https://github.com/superzanti/ServerSync/releases