ServerSync

ServerSync

48.5k Downloads

sync config or other directory

kaiserdj opened this issue · 16 comments

commented

Serversync Version: serversync-3.2.1

Minecraft Version: 1.12.2

Issue:

First of all congratulations on the mod, it is incredibly useful.

I have a problem with the synchronization, to synchronize mods it works perfectly, but I can synchronize for example the entire config folder, excluding some file.

I have tried in a thousand ways and I have not succeeded, I crashed the entire server

Thank you

commented

I have used the version that you have indicated to me, I have noticed that the "Contents of getDiffableFilesFromDirectories", it keeps outputting files that it is supposed to ignore

I hope it can help you discover what is happening and thx ^^

commented

Yep that log output is just every file in every configured directory. It has not filtered out ignored files at that stage.

commented

I'll pick this up tomorrow and have a dig into it further.

The only noteworthy oddity in the list of files is this one: mods\# LibLoader.jar, it shouldn't be causing an issue but it is a rather odd file name.

Looks like we are getting the same null pointer so the issue is somewhere deeper than the initial file fetch.

commented

ServerSync is failing to access one of the configured directories.

Do you have special permissions set on config?

commented

I do not have any special permission configured, I am from windows 10 and I am the administrator of the pc with an administrator account and the configuration of the serversync you have attached above

commented

Hmm, it's getting a null pointer while trying to gather the files available for sync. I'll load up a 1.12 test server and see if I can reproduce it.

commented

I think it may be because I am trying to share configuration files that the server itself is using for mods, so it does not have access to those files because they are currently in use.

It can be that?

commented

Hmm, possibly if the server is holding a lock level on the file that prevents 'read' access.

commented

What version of Java do you have installed?

commented

What version of Java do you have installed?

jdk: 1.8.0_241

commented

serversync-3.4.0-debug.jar.zip
Give this debug version a try. I have tweaked the file collection to avoid nulls and added some debug logging around it.

Worst case scenario we might get some more useful log output 😊

commented

Well I am basically at a loss with this one, the null pointer appears to be getting thrown inside java functions.

Could possibly be failing to hash one of the files.

You could try this where I switched to a concurrent map: https://github.com/rheimus/ServerSync/actions/runs/68800162 I somewhat doubt it will fix the issue though.

Do you get this same issue if you run ServerSync manually without forge loading it?

commented

Included configs is only relevant if you add entries to the config_include_list. Its essentially a 'whitelist' version of sharing configs.

Thanks for the logs! Will be useful to look into why this may have been solved.

commented

With the version that you have told me, it does not give me a single problem, it is incredible ❤️ 💯
Just in case, I show my config and data in case you want to see something that works for you

  • Config sereversync:

serversync-server.cfg.txt

  • Log serversync(working perfectly):

serversync-server.log

  • Crash so you can see all the mods it's working with(Removing serversync-3.4.0-debug.jar version so it won't crash from repeated mod):

crash-2020-04-02_10.39.43-server.txt

By the way, reviewing the serversync log, I realized that it says:
Found 0 included configs in
I don't know why he says he hasn't found anything if he then shares everything

Thank you so much for everything ❤️

commented

Closing this as task complete.