Error Freezes
kaiserdj opened this issue · 4 comments
Serversync Version: serversync-3.4.0-all.jar
Minecraft Version: 1.12.2
Forge Version: 12.23.5.2838
Issue:
It freezes without doing anything until the timeout expires, and it doesn't finish syncing all the files
serversync-server.log
serversync-server-connection-from--127-0-0-1.log
serversync-client.log
Fantastic bug report by the way 👍
Seem's to have died while trying to fetch the file size of one of the files. Unfortunately my logging is garbage there 😂 I don't log which file it was trying to work on. Will have to fix that.
Nvm not giving myself any credit there, the server log for the connection has which file is being processed.
config\brandon3055\contributors.json
I have seen this file cause issues before, pretty sure it gets removed at some point during the lifecycle of forge, adding it to your server ignore list would be a temporary fix until I add some guards on the server side for missing files.
Early test files can be found here: https://github.com/superzanti/ServerSync/actions/runs/72526484
Latest changes include some basic "File went missing" handling for the server, it is not great at the moment as it will just send a 0 byte file to the client and log an error to the server owner.
I have tested it with this version and it has not given me any error, thank you very much ❤️