
[Suggestion] JEI search compatibility
CalaMariGold opened this issue ยท 6 comments
It would be great if typing the name of the set bonus into JEI would show all items that use that set, similar to how tooltips function.
Thanks!
I'm actually not sure why the JEI tooltip search is failing to find the set names (with Set Bonus tooltips turned on). A quick look at some of JEI's code and it seems like it should be able to find it...
...but it doesn't. I'll see if mezz can enlighten me on his discord. I'm not familiar enough with JEI's inner workings.
EDIT: After scanning more of JEI's code, it looks like they cache all tooltips for searching during client startup. Set Bonus is not compatible with this by nature because sets are defined server-side and synced to joining clients.
I might be able to hack into JEI's caches during runtime and update them on certain triggers to include such info, but...that's probably another feature for the backburner right now
Unfortunately that was over a year ago. No way I'm going to remember...but if you plan to look into it, you'll want to grab the JEI source for reference.
Keep in mind that Set Bonus is enforced from the server side, so if JEI is caching tooltips during client startup (before connecting to a server), then the only thing you can do is retroactively alter JEI's tooltip data in its cache after connecting (and whenever the particular player discovers a set, etc).
After scanning more of JEI's code, it looks like they cache all tooltips for searching during client startup.
where exactly is this in the code @Laike-Endaril? for future reference and a possible fork