[1.12.2] Game crashes when set states change with HEI loaded
SonicX8000 opened this issue ยท 3 comments
Minecraft: 1.12.2
Forge: 14.23.5.2860
Mods:
Baubles-1.12-1.5.2
FantasticLib-1.12.2.057
HadEnoughItems_1.12.2-4.27.3
PotionCore-1.9_for_1.12.2
SetBonus-1.12.2.029
Crash:
crash-2025-04-21_22.10.56-client.txt
Log:
latest.log
Debug:
debug.log
MC-1.12.2_SetBonus_Crash.mp4
For some reason if an item has a Set Effect, prob if by itself as that's what I had config'd before. The game will freeze and then force close. In a modded survival world... the game was softlocked prob due to it "crashing" but it didn't force-close the game, but I couldn't move around.
Potion Core isn't needed as I thought it was due to modded attributes but I edited my config to include vanilla attributes and... the same thing happens.
Here's the config that I was using at the time of testing... though you have to either rename .txt to .cfg or copy what's in the text file as github doesn't allow cfg files to be uploaded directly.
1.12.2.009+.txt
I am unsure if this applies for Potion Effects or Enchantments as I've only been using Attributes. Also unsure if it's due to my config as I copied the lines from my old config into the new fresh config since you added support for the Aether & Trinket Slots.
In this case, the old config would still be compatible, but that's beside the point.
Thanks for the log file. Looks like I need better code isolation on some of my mod compat. I'll get to fixing this.
Looks like I was wrong; HEI (Had Enough Items) is not backward-compatible with JEI, yet uses JEI's mod id. Because of this, my mod sees that "JEI is loaded" (even though technically it is not; HEI is loaded instead). In turn, because HEI has different internal code than JEI, we get this crash.
I can prevent the crash for sure. Hopefully I can also make the compat work for HEI, I'll take a look.
Btw, there is a good reason that HEI uses JEI's mod id (more automatic compat with existing mods made to interact with JEI). I just didn't know that the relevant internal code would be changed.
Edit:
Actually, the supposed "missing class" seems to be there in HEI under the same name and package, so now I'm not sure what's up. I'll have to spend a bit more time looking into this.
More edit:
(I had pulled the HEI code from the 1.12 branch the first time, when I should've gotten it from the cleanroom branch; the class is, in fact, removed in the cleanroom branch)