I have been testing my modpack in survival for a while and started to experience the music just stopping for no reason.

I finally managed to narrow down the issue and I believe it has to do with newer versions of Set Bonus and how it handles potion effect timers.

here's my log: log

To recreate the bug:

• equip any of the sets that give potion effects on timers
• keep transitioning between different triggers in Music Triggers (e.g: enter the desert, wait for the desert song to play, then leave the desert and wait for another song to play, rinse and repeat until the error happens.)

Notes:

• This is from a separate instance that utilizes Set Bonus and its dependencies, Music Triggers and its dependencies, and Behgameon RPG Additions, which adds baubles that do nothing on their own (and optifine).

• The rings from that mod are being used in my modpack alongside Set Bonus to make my own type of potion rings. This is why in the log, it also displays that some potion effects were not found (because I didn't have the mods that added those potion effects).

• I believe this is related to the fact that Music triggers 6.3.1 probably checks for conditions every tick, and if the list of conditions updates unexpectedly (in this case due to potion effect timers), it throws an exception and freezes the soundtrack.

Just tested previous versions of SB, and as I expected, on version 027, which mentions this in the changelog: "Fixed vanilla's incorrect potion combination / sync code, at least for Set Bonus. This means if you have a set that gives constant strength 1, and drink a strength 2 potion, you can now see the correct duration.", is where the problem starts

here is a cleaner log: https://mclo.gs/RlQCPps

update: the error seems to happen on older versions of SB too, it is just much more rare for some reason.

From what I got with my experience, this seems to be purely an issue with Music Triggers 6.3.1, most likely related to trigger detection trying to force a change in a list when it is not supposed to. So Set Bonus has nothing to do with this, it just makes it happen more frequently because effect timers can cause multiple trigger detections.

So far I haven't gotten it to happen at all, on the indev version of your modpack I have from before. I also tried on a minimal setup (music triggers + set bonus, with a 2-tick invisibility every 4 ticks when a diamond sword is in hand, and your music triggers configs imported from the version of the pack I have)

Based on the stacktrace, I have a feeling this can technically happen without Set Bonus installed, but since I haven't found a good way of quickly replicating the issue yet, that's hard to test.

I see you released a new version of your pack yesterday, though, which I was planning to try anyway, so I'll grab that and see if I notice it through normal gameplay

How often can you get this to happen if you try to on purpose?

Yeah, this is an extremely weird issue. I think it’s better to post it on the Music Triggers issues. Though I need to check if it even happens on more recent versions. Since I was so close to release my new modpack version, I didn’t want to update any new mods and potentially break things on the last minute.

If you do end up posting it on the Music Triggers issue tracker, feel free to reference this issue (though ofc make sure to include the important details directly). I'll post here if I notice it during gameplay