Set Bonus

Set Bonus

10M Downloads

[Suggest] Enchantment Set Bonus

CalaMariGold opened this issue ยท 11 comments

commented

Something that would be really amazing is if we can give specific items in a set enchantments that pertain to that piece of gear. This would make the mod perfect!

Thanks!

commented

This is now a thing in the latest version (1.12.2.023)

commented

Ie. that one item would have the enchantment, but only if you meet the requirements for it (eg. at least 2 set pieces)?

I had denied a similar request once before due to complexity, but this may be possible.

It will probably still be a while before I get around to going through Set Bonus again though; I'm very busy with another project atm

commented

Seconded, I'd love to see this enhancement.

commented

Nice!

I'll still leave this open as something to look into eventually, but it's good to know there's a mod synergy you can use to do it

commented

I found out you can use the Wards mod which convert all enchantments into potion effects. Works perfectly.

commented

Does it handle modded enchantments as well? Do you have any issue applying part/tool specific enchantments like depth strider or fire aspect?

commented

It's actually quite interesting. Modding enchantments work fine for the most part (except enchantments for different types of gear like scrolls). You can't apply an enchantment to a specific gear piece, so it's like all your equiped items have that enchantment. I created a mending set bonus and it applies to all my gear. Things like depth strider works fine.

commented

I did a quick test and found only base minecraft enchants were converted to potion effects. I have a huge number of enchants in my pack, this is my potion dump after installing Wards:

image

Any comments? Unless I missed something, this may be better handled-natively with set bonus.

commented

For me, it seems like not all enchantments will convert. Not sure why. Most modded enchantments are available in my potions dump but some are missing, notably Ender Killer from EndReborn.

commented

Thanks for the feedback. I suppose this means this feedback is valid again haha.

commented

I cant seem to get wards effects to work. Like Mending, Depth Strider, etc.

Mind sharing what you did to get them to work?

EDIT: Never mind, I figured out what I was doing wrong. :D