Shield Expansion

Name	Version
Minecraft	1.20.1
Minecraft Forge	47.3.12
Shield Expansion	1.1.7a

Crash Reports:

crash-2024-12-06_23.52.21-client.txt
crash-2024-12-06_23.54.22-client.txt
crash-2024-12-06_23.55.33-client.txt

For context, I'm playing on a server and it seems that I crash whenever entering a gui with a damaged shield on my hotbar - unsure whether the shield is broken somehow due to me taking it out of a Refined Storage system.

Offending code seems to be

Shield-Expansion/src/main/java/org/infernalstudios/shieldexp/events/ShieldExpansionEvents.java

Lines 244 to 247 in 0299225

    
           public static Double getShieldValue(Item item, String value) { 
        
               String key = ForgeRegistries.ITEMS.getKey(item).toString(); 
        
               return SHIELD_STATS.containsKey(key) ? SHIELD_STATS.get(key).get(value) : SHIELD_STATS.get("shieldexp:default").get(value); 
        
           }

So I'm assuming either SHIELD_STATS.get(key) or SHIELD_STATS.get("shieldexp:default") is returning null(?)

Fixed by #49

	public static Double getShieldValue(Item item, String value) {
	String key = ForgeRegistries.ITEMS.getKey(item).toString();
	return SHIELD_STATS.containsKey(key) ? SHIELD_STATS.get(key).get(value) : SHIELD_STATS.get("shieldexp:default").get(value);
	}

Share to