Shimmer

Shimmer

Mods
330k Downloads

Bloom particles often turn black（泛光粒子经常变黑）

Kiuju79 opened this issue · 3 comments

commented

Minecraft Version

1.19.2 forge

ModLoader

Forge

Shimmer version

Shimmer-forge-1.19.2-0.1.14

Modpack info or mod list(please reduce mod range)

Embeddium

The latest.log file and hs_err_pidXXX if exists

no

optifine , Rubidium , flywheel or any rendering related mods. mod version is required.

No response

Issue description

Bloom particles often turn black.
（泛光粒子经常变成纯黑色）
1

Steps to reproduce

  1. 多次生成粒子(不确定)，泛光粒子有低概率变黑，需要重载资源包或重启游戏。

  2. 重载资源包，反光粒子也有概率变黑，需要再次重载资源包或重启游戏。

Other information

No response

commented

经过测试在没有安装Embeddium的情况下触发概率小了很多，但依然会触发。

commented

Shimmer/Forge/src/main/java/com/lowdragmc/shimmer/forge/core/mixins/ForgeParticleEngineMixin.java

Lines 94 to 100 in 416b601

/**
* {@link ParticleRenderType#CUSTOM} can implementation custom render logical not defined
* for example {@link net.minecraft.client.particle.ItemPickupParticle}
* where {@link net.minecraft.client.renderer.RenderType#entityShadow(ResourceLocation)} is used
* it will use {@link net.minecraft.client.renderer.RenderStateShard.LightmapStateShard}
* which will call {@link LightTexture#turnOffLightLayer()}, so we need turn on it if needed
*/

commented

fix by 416b601