crashes on quilt because fabricId cannot be null
4ns0n opened this issue · 3 comments
The mod seems to be incompatible on quilt due to it passing null here as quilt doesn't accept that could you fix this?
I know that quilt compatibility is not provided now due to it still being in beta (#32), but this seems very easy to fix. This +1-1 patch works for me:
diff --git a/Fabric/src/main/java/com/lowdragmc/shimmer/fabric/client/ShimmerModClient.java b/Fabric/src/main/java/com/lowdragmc/shimmer/fabric/client/ShimmerModClient.java
index 666b305..96cec88 100644
--- a/Fabric/src/main/java/com/lowdragmc/shimmer/fabric/client/ShimmerModClient.java
+++ b/Fabric/src/main/java/com/lowdragmc/shimmer/fabric/client/ShimmerModClient.java
@@ -182,7 +182,7 @@ public class ShimmerModClient implements ClientModInitializer, SimpleSynchronous
@Override
public ResourceLocation getFabricId() {
- return null;
+ return new ResourceLocation("shimmer");
}
@OverrideIf the maintainer(s?) would like me to open a PR for this please let me know.
can someone please get me a 1.19.2 version with this patch, I have just spent the last 1.5 hours trying to patch it myself with no experience in java, jar files, compiling or decompiling.
