[Suggestion] Replace `ClipContext.Block.COLLIDER` with `ClipContext.Block.VISUAL`
70CentsApple opened this issue · 1 comments
Currently, the mod also collides with perspectives when encountering blocks such as glass, while in newer versions of Minecraft, the perspective does not collide with blocks such as glass.
The way to fix this is really simple, replace ClipContext.Block.COLLIDER
with ClipContext.Block.VISUAL
here.
The definition of and difference between COLLIDER
and VISUAL
are shown below:
1.20.1: net.minecraft.world.level.ClipContext
This little fix might not bring significant changes, but it fixes mods that modify camera collisions of blocks by modifying the BlockBehaviour.BlockStateBase::getVisualShape
method (such as mine, Modify Camera Collision).
I could make a PR for this issue, but if there's any reason why I shouldn't, please let me know.