Shoulder Surfing Reloaded

Shoulder Surfing Reloaded

Mods
26M Downloads

Occasional ConcurrentModificationException

Crystal1921 opened this issue ยท 1 comments

commented

Description

ShoulderSurfing/neoforge/src/main/java/com/github/exopandora/shouldersurfing/neoforge/ShoulderSurfingNeoForge.java

Line 41 in 2eb519f

public void clientSetup(FMLClientSetupEvent event)

According to https://docs.neoforged.net/docs/1.21.1/concepts/events#the-mod-lifecycle

Steps to Reproduce

If multiple mods do not use enqueueWork here simultaneously, it may cause a java.util.ConcurrentModificationException.

Minecraft version

1.21.1

Game Logs

Here are a case with Yuushya Modelling https://mclo.gs/dj9QcKC

Additional Information

No response

commented

Thanks for the report. The crash log shows that Yuushya Modelling caused the crash. In the event you mentioned, Shoulder Surfing Reloaded only registers event listeners, which use synchonized lists. This can be done in parallel and should never lead to a crash.