Duplicate tooltips in accessory slots when using Accessories/Accessorify
Closed this issue ยท 1 comments
Issue Description:
When using Shulker Box Tooltip together with Accessories and Accessorify, items equipped in accessory slots display two tooltips instead of one.
What happens:
Equipped items in accessory slots show duplicate tooltips when hovered.
What you expected to happen:
Each equipped item should only show a single tooltip.
Steps to reproduce:
- Install Shulker Box Tooltip with Accessories and Accessorify.
- Equip any item into an accessory slot.
- Hover over the equipped item in the accessory slot.
Affected Versions:
- Shulker Box Tooltip: 5.2.8+1.21.7
- Minecraft: 1.21.8
- Fabric Loader: 0.17.2
- Fabric API: 0.133.4+1.21.8
- Accessories: 1.3.2-beta+1.21.8
- Accessorify: 2.2.1+1.21.8
Screenshots/Images:
Your most recent log file where the issue was present:
Not needed for this bug; the issue can be reproduced without it.
Hi, I have made a partial fix to this issue:
I fixed a bug on my end where the tooltip rendering was always rendered (regardless of whether the item is a shulker box), but the issue still persists when trying to lock a preview-able item.
This is due the Accessories bypassing the normal tooltip rendering that is breaking the locking feature entirely.
At a quick glance at their code, it seems the culprit is the guiGraphics.renderTooltip call at https://github.com/wisp-forest/accessories/blob/fe895c77c9cf860372d53fd313b4880d0dfc2f62/common/src/main/java/io/wispforest/accessories/client/gui/AccessoriesScreen.java#L725