Stack overflow while using saw
ProOrange opened this issue · 4 comments
Versions
- Silent Gear: 2.6.16
- Silent's Gems: 3.7.13
- Silent Lib: 4.9.6
- Forge: 36.1.2
- Modpack: TNP Limitless 3
- Optifine Installed: No
Expected Behavior
Tree should be chopped without problems
Actual Behavior
Crash. My iron saw was almost broken, and when i tried to chop tree server is crashed with StackOverflow exception
Links/Images
- https://pastebin.com/UKEQThwA (log from server)
Steps to Reproduce the Problem
Not sure, because don't want to restart server again, it take lot of time with this modpack, but more likely
- Have an saw with low remaining durability
- Chop as big as possible tree
I thought the distance check would handle that, but I guess not. Will need to track the recursion depth as well. Your stacktrace shows about 374 entries, so I'll try 300 max. Probably 100-200 just to be safe.
@SilentChaos512 actually in this forest were lots of similar trees, could this bug relates to saw durability?
Nah, it's not the durability. The new code that lets the saw chop down nether fungi also can make it chop down multiple trees as a side effect. I should probably take another look at that as well. Maybe make the code behave differently for the fungi only.