Silent Gear

Silent Gear

30M Downloads

Visual Glitch after only changing the Servers silentgear-common.toml

zipacna opened this issue ยท 0 comments

commented

Versions

  • Silent Gear: SilentGear-1.15.2-1.11.4+187.jar
  • Silent's Gems: N/A (no found but could have been overlooked)
  • Silent's Mechanisms: SilentMechanisms-1.15.2-0.8.0+59.jar (not sure if relevant)
  • Silent Lib: SilentLib-1.15.2-4.6.6+59.jar
  • Forge: forge-31.2.47
  • Modpack: HR New Beginnings 2.6
  • Optifine Installed: No (not to my knowledge, assuming no as zoom with Z on qwertz does not work)

Info

First up I wanted to say that everything is working as expected, this bug is just a visual glitch. I hope the Issue category fits, this is more a bug report than a feature suggestion, but "If this doesn't look right, choose a different type" could apply (as the issue is a visual "bug"), depending what "this" means, looking at you JavaScript / ProgrammerHumor Subreddit ;)

Expected Behavior

Changing the config on the Server should be the deciding factor for showing the amount a repair kit is filled (calculations and repair/crafting work as expected regardless).

Expected Visual after Workaround

expected-visual-after-workaround

Debug Tooltip Repairkit fixed, Matching Configs

debug_tooltip_repairkit_fixed_matching-configs

Actual Behavior

The display of the repair kit overflows into the next slot (will be hidden if there is an item).

Inventory Repair Kit overfilled, mismatching Configs

inventory_repairkit_overfilled_mismatching-configs

Debug Tooltip Repair Kit overfilled, mismatching Configs

debug_tooltip_repairkit_overfilled_mismatching-configs

Steps to Reproduce the Problem

  1. Change Config on the Server, see "Server silentgear-common.toml Repair Kit Section (changed)" below;
  2. Restart Server (apply changes).
  3. Overfill Repair Kit
  4. ...
  5. Profit?

Server silentgear-common.toml Repair Kits Section (changed)

server_silentgear-common-toml_repairkits

Client silentgear-common.toml Repair Kits Section (unchanged, as modpack)

client_silentgear-common-toml_repairkits

Workaround

Updating the client config with the server config's changes and restarting the client works (probably not feasable on a modpack level from the perspective of a server admin).

Side Notes

All in all the Silent Mods are pretty well made and have depth, I would even say the rival Tinker's Construct. If not obvious server config via vim and client config via Notepad++; As a side note, how difficult would it be to allow filling of a repair kit with an entire stack instead of spacing out the items in the crafting grid? If any of my concerns have already been patched in another version this Issue can be closed with some snarky comment ;)

Just for reference, some maybe related issues:

  • #237 (maybe this helps with my final suggestion)
  • #151 (maybe related due to tooltip updates)