Silent Gear

Silent Gear

30M Downloads

Material Modifiers

SilentChaos512 opened this issue ยท 0 comments

commented

What Should Be Added or Changed?

A material modifier system. This will handle both grades and starlight charging. It allows extra modifiers to be assigned to material instances. The modifier type will handle reading/writing information to the item's NBT and will be compatible with existing graded and charged items. Other mods could register their own modifiers.

Why Should This Be Done?

The modifier system will provide a common interface for future expansions, and clean up the existing code base a little bit. Stat bonuses can be handled by the material modifier, instead of relying on special cases (like for grades) or events (for charged enchantments).

Related Issues

  • The presence of charged enchantments is not at all obvious on the finished part or gear item. Having some common system like this in place will make adding tooltips a little easier. Of course, parts could be made with materials of different charge levels. While unlikely, that still has to be accounted for.
  • Charged enchantments being enchantments is another problem. While it works, there are some unintended effects (like enchanted books) created by some other mods that lead to confusion. This can help fix that. A Mixin can be used to apply the enchanted glow effect like before.