Add composter support for Silent Gear plants
Syndaryl opened this issue · 5 comments
What Should Be Added or Changed?
The various seeds, saplings, fruits, and leaves should be added as compostable items, for consistency with Vanilla.
The obvious ones are these:
- silentgear:flax_seeds
- silentgear:fluffy_seeds
- silentgear:netherwood_sapling
- silentgear:nether_banana
- silentgear:netherwood_leaves
- silentgear:flax_flowers
For consideration, possibly also the crop products:
- silentgear:flax_fiber
- silentgear:fluffy_puff
As vanilla doesn't directly allow composting animal products, I think it would be most correct to exclude sinew and fine silk thread. That said, pumpkin pie contains eggs and can be composted. Likewise, the golden apple and carrot cannot be composted, so I think it is correct to exclude the golden banana.
Why Should This Be Done?
- Improve consistency with Vanilla; vanilla trains players that saplings, seeds, leaf-dropped fruits, crop produce, and leaves can be composted.
- Allow satisfying disposal of surplus flax and fluffy seeds, which seriously get out of control after a while
- If you really want to bin your nether bananas for bonemeal, meh. Sure. Vanilla lets you compost pumpkin pies for heavens sake.
Huh, there used to be support. I guess the hook I added in Silent Lib broke in 1.17.
Hi,
I also have this issue on 1.18.2 version 2.10.6. I guess it's still hasn't been fixed...
No rush but it's kind of weird
@SilentChaos512 you need to call ComposterBlock.COMPOSTABLES.add(your_seed_item).
adding seeds to a tag is not enough.