Silent Gear

Silent Gear

Mods
19M Downloads

Refactor of keybinds in 1.19.2-3.1.0 causing Z/C events to fire multiple times

GarthF opened this issue ยท 0 comments

commented

Versions

1.19.2-3.1.0 and up

  • Silent Gear: 1.19.2-3.1.2
  • Silent's Gems: N/A
  • Silent Lib: 1.19.2-7.0.3
  • Forge: 43.2
  • Modpack: N/A
  • Optifine Installed: No

Expected Behavior

Next and Back should fire once, traversing through the tooltip tabs as normal

Actual Behavior

Materials and the Blueprint book both appear to be navigating twice with each keypress of Z or C, rather than just once.
For example, on materials with just "Main" and "Toolrod", nothing happens (the navigation loops back to "Main"). It is impossible to get to Toolrod. On materials with three properties, e.g. "Main", "Toolrod", "Tip", the tab is changed two at a time, e.g. from Main, it goes to Tip instead of Toolrod.

I tested this in a vanilla instance with just JEI and Silent Gear installed, and was able to verify that the issue first appears in 3.1.0. 3.0.8 behaves normally, with the keypress only navigating one tab.

I had a look at the commit for 3.1.0 and I see there was a change done in sideproxy.java to how the keypress events are bound, so its just a hunch but that might be where things are going weird.

Steps to Reproduce the Problem

  1. Setup a forge instance, Minecraft 1.19.2, forge 43.2.0
  2. Add JEI, Silent Gear (3.1.0) and Silent Lib (7.0.3)
  3. Create a world and examine iron ingot in JEI, Z and C should jump the tab by two menu items each press.