Silent Gear

Silent Gear

19M Downloads

Config file not correct. Correcting (endlessly repeating)

phazonxl opened this issue ยท 6 comments

commented

Versions

  • Silent Gear: 3.1.2
  • Silent's Gems: x.x.x
  • Silent Lib: 7.0.3
  • Forge: 43.1.55
  • Modpack: All The Mods 8
  • Optifine Installed: No

Expected Behavior

I expect the config file to be corrected ONCE (if at all). (The server is a clean and fresh startup)

Actual Behavior

[11Jan2023 09:27:39.420] [Thread-0/WARN] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Configuration file /var/games/minecraft/servers/allthemods8/config/silentgear-common.toml is not correct. Correcting
[11Jan2023 09:27:41.420] [Thread-0/WARN] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Configuration file /var/games/minecraft/servers/allthemods8/config/silentgear-common.toml is not correct. Correcting
[11Jan2023 09:27:53.421] [Thread-0/WARN] [net.minecraftforge.fml.config.ConfigFileTypeHandler/CONFIG]: Configuration file /var/games/minecraft/servers/allthemods8/config/silentgear-common.toml is not correct. Correcting

I've had a friend use a TOML verification tool and it PASSES. The config file will keep trying to correct itself, but the file is exactly the same. He recommended I bring this error to the attention of SilentGear devs.

Links/Images

  • (Link)

Steps to Reproduce the Problem

  1. Launch a brand-new All The Mods 8 Minecraft server on FreeBSD with OpenJDK 17 (Also tried with Direwolf from FTB)
  2. Wait for server to create world and settle
  3. Watch as the error occurs over and over. On my machine, it creates the file named "silentgear-common-1.toml.bak", then again but in sequential numbered files "silentgear-common-2.toml.bak" and so on...
commented

Having this same issue. My logs are 95% comprised of these messages

commented

Same here, has anyone found a fix?

commented

Could it be that at line

.define("dummyToolTier", GearHelper.DEFAULT_DUMMY_TIER);
(and line 220) it should be calling defineEnum?

commented

Any update?

commented

@skwirl42 is correct that both 214 and 220 need changed to .defineEnum - confirmed working after applying the following patch.

SG576.patch

index 8e47651f..98d0c1fb 100644
--- a/src/main/java/net/silentchaos512/gear/config/Config.java
+++ b/src/main/java/net/silentchaos512/gear/config/Config.java
@@ -211,13 +211,13 @@ public final class Config {
                         .comment("The item tier assigned to gear tool items.",
                                 "Leave this alone unless you are trying to work around mod compatibility issues!",
                                 "Normally, this value is not used for anything. But some mods mistakenly check it.")
-                        .define("dummyToolTier", GearHelper.DEFAULT_DUMMY_TIER);
+                        .defineEnum("dummyToolTier", GearHelper.DEFAULT_DUMMY_TIER);
 
                 dummyArmorMaterial = builder
                         .comment("The armor material assigned to the gear armor items.",
                                 "Leave this alone unless you are trying to work around mod compatibility issues!",
                                 "Normally, this value is not used for anything. But some mods mistakenly check it.")
-                        .define("dummyArmorMaterial", GearHelper.DEFAULT_DUMMY_ARMOR_MATERIAL);
+                        .defineEnum("dummyArmorMaterial", GearHelper.DEFAULT_DUMMY_ARMOR_MATERIAL);
 
                 {
                     builder.push("enchanting");
commented

@skwirl42 is correct that both 214 and 220 need changed to .defineEnum - confirmed working after applying the following patch.

SG576.patch

index 8e47651f..98d0c1fb 100644
--- a/src/main/java/net/silentchaos512/gear/config/Config.java
+++ b/src/main/java/net/silentchaos512/gear/config/Config.java
@@ -211,13 +211,13 @@ public final class Config {
                         .comment("The item tier assigned to gear tool items.",
                                 "Leave this alone unless you are trying to work around mod compatibility issues!",
                                 "Normally, this value is not used for anything. But some mods mistakenly check it.")
-                        .define("dummyToolTier", GearHelper.DEFAULT_DUMMY_TIER);
+                        .defineEnum("dummyToolTier", GearHelper.DEFAULT_DUMMY_TIER);
 
                 dummyArmorMaterial = builder
                         .comment("The armor material assigned to the gear armor items.",
                                 "Leave this alone unless you are trying to work around mod compatibility issues!",
                                 "Normally, this value is not used for anything. But some mods mistakenly check it.")
-                        .define("dummyArmorMaterial", GearHelper.DEFAULT_DUMMY_ARMOR_MATERIAL);
+                        .defineEnum("dummyArmorMaterial", GearHelper.DEFAULT_DUMMY_ARMOR_MATERIAL);
 
                 {
                     builder.push("enchanting");

How to apply this patch? The game keeps creating .bak files while loading.