Silent Gear

Silent Gear

Mods
31M Downloads

Error Spam "Cannot invoke "String.isEmpty()" because the return value of "net.minecraftforge.event.AnvilUpdateEvent.getName()" is null"

Freedbot opened this issue · 4 comments

commented

Versions

  • Silent Gear: 3.6.3-3.6.5
  • Silent Lib: 8.0.0
  • Forge: 47.3.5
  • Modpack: In dev. To be released within 1-2 weeks. Available upon request.
  • Optifine Installed: No, but I have embeddium, oculus, krypton, modernfix, radium, saturn, and just about every other breaking optimization mod installed.

I'm not certain what (if any) in-game consequences would come of this, but the error error spams 92 times total. As I work on the pack more I'll try to narrow down which mods specifically are involved, but I thought it would be a good idea to make the report now before I call it a night.

What I've tried so far.

  • Tried downgrading to 3.6.3.
  • Disabled KubeJS (btw, allowAsyncStreams=false, because I do have that concurrent exception error sometimes).
  • Disabled Vtweaks.
  • Disabled Exchangers.
  • Disabled at once: Client Tweaks, clientcrafting mod, Fast Suite, Fastload-Reforged, Ferrite Core, ImmediatelyFast, Krypton Reforged, Mobtimizations, ModernFix, Radium, Saturn, ServerCore, Smooth Boot (Reloaded), Yeetus Experimentus.
    • This was a last moment hail mary move. No difference, but it rules out a few problematic mods.

Hastebin latest.log

Steps to Reproduce the Problem

  1. Boot pack.
  2. Load world.
  3. Observe this error repeatedly as the game presumably iterates all Silent Gear materials.
commented

I just did a sanity check and installed a fresh instance with ONLY the lasted Forge, Silent's Gear, and REI installed along with their dependencies. This bug is confirmed, it's just a question of which of the two mods to blame.... Or Architectuary or Cloth Config I guess.

commented

Looking at the line of code in question, IntelliJ is showing me a warning. Maybe Forge changed something with their anvil events and I didn't notice. But it should be easy to fix. If I don't address it in the next couple days, please give me a poke.

commented

First of all, thank you. Also, this error would have shown up except that REI's newish anvil recipe lookup feature is super noisy in the logs. I'm actually more inclined to blame REI than you now that I've figured out that it only errors due to them. REI should handle the null value more gracefully. Still, it does mean you're not handling some nitpick on Forge's end properly. I'll bug you again later as promised if it isn't resolved when I release the pack in a couple days.

commented

Does this count as a poke?

  • 👍1