Silent Gear

Silent Gear

Mods
35M Downloads

[BUG] Duplicate way of coating materials

ShinryuAspect opened this issue · 2 comments

commented

Versions

  • Silent Gear: 4.0.12
  • Silent's Gems: N/A
  • Silent Lib: 10.3.1
  • Neoforge: 21.1.107
  • Modpack: N/A
  • Optifine Installed: No

Expected Behavior

Don't really know if I should clarify this as a bug, but here goes nothing. I'm currently running latest available version of ATM10 (2.30) and the questline for Silent Gear states the coating of an item is done through a Coating Smithing Template (something new to 1.21 version on SG which wasn't present on 1.20, if I am not mistakening). Up to this point, everything's alright. The "problem" comes when you find out there's a second method of coating via a Coating Blueprint.
Is this duplicate method of coating intended or is it some remainder code from previous versions in which the Coating Smithing Template wasn't a thing?

I chose not to post this as a feature request as it seems like a minor bug from my point of view, but feel free to poke me in the eye if you find this is intentional.

Actual Behavior

Probably getting rid of the "deprecated" way of coating in favour of the Smithing Template? I don't really know, at this point, it's just mere curiosity.

Links/Images

  • N/A

Steps to Reproduce the Problem

N/A

commented

The answer is sort of yes to both, but I think my intention (which I probably forgot during the 3-month-long porting process lol) was to remove the blueprint in favor of the smithing template. But with issues like #756 still popping up, I'm not in a hurry to remove it yet.

The design philosophy of Silent Gear is usually to make its mechanics as close to vanilla as possible, at least in terms of crafting costs and requirements. Since coating gear items is an adaptation to mimic how vanilla handles netherite, using the smithing template makes the most sense.

In short, the coating blueprint should be removed. Eventually.

commented

Thank you for the quick answer. As I stated, it was more just mere curiosity than a kind of "bug report", so no need to hurry, just wanted to make sure if it was something intentional, leftover from porting or whatever else. I'm more than familiar with development processes and I know the time it takes, so keep up the good work with such and amazing mod.

Marking this as closed as I got my question/bug report answered. Feel free to reopen it if you find it needed,

  • 👍1