Silent Gear

Silent Gear

36M Downloads

Grader is bugged and will mess up alloy NBTs

potatom4n opened this issue ยท 6 comments

commented

Versions

  • Silent Gear: 4.0.17
  • Silent Lib: 10.4.0
  • NeoForge: 21.1.143
  • Modpack: All The Mods 10 (2.42)
  • Optifine Installed: No

Expected Behavior

The Grader to only change the grade of an alloy

Actual Behavior

Messes up the NBT data, randomizes the order of the alloy components, different MAX ingots have different NBTs and cannot be stacked. Also will sometimes be put in the output and sometimes be kept in the input slot, the grade doesn't seem to matter for that as sometimes it outputs on D sometimes it outputs at MAX etc.

Steps to Reproduce the Problem

  1. Use the grader on an alloy.
commented

Same, since upgrading to All The Mods 10 (2.42)

Silent Gear: 4.0.17
Silent Lib: 10.4.0

From advanced tooltips, I see that the grader grades alloy components individually now. So, 4 ingot alloy gets a rating for each of the 4 parts separately on each grade attempt, but the grade of the alloy ingot doesn't change at all.

commented

If this is new in recent versions, it might be caused by #792.

commented

can_grade_parts is set to false, but the issue now, it seems, is that the grader now assumes alloys are itemStacks, because it has a material list.

commented

Also experiencing this (same mod version, but in FTB Evolution), glad a fix is on the way!

commented

This is fixed in 4.0.18 so this could probably be closed now?

commented

Yes, I meant to close this after merging the PR. Thank you!