Silent Gear

Silent Gear

36M Downloads

Inconsistent range damage description

uhloin opened this issue ยท 3 comments

commented

Versions

  • Silent Gear: 4.0.20
  • Silent's Gems: N/A
  • Silent Lib: 10.4.0
  • Forge: NeoForge 21.1.168
  • Modpack: N/A
  • Optifine Installed: No

Expected Behavior

Clear and the same information about bonuses

Actual Behavior

Ranged Damage information is different in tooltips before (1), during craft (2) and after crafting (3)

Links/Images

  • (Link)

Steps to Reproduce the Problem

  1. Install JEI

  2. Create Tip Upgrade Blueprint, press 'U' to show "Usage" by JEI. Switch to Silent Gear tab, wait until show Redstone case, switch to Tip Upgrade Tab. Can see:
    "Attack Damage: + 2... Ranged Damage: +2"

Image

  1. Put "Tip Upgrade Blueprint" and Redstone to crafting grid. Hover resulting item (tip upgrade)
    Can see only Attack Damage:
    "Attack Damage: + 2"

Image

  1. The same if put to grid bow and tip upgrade and hover tip upgrade.

  2. But if hover resulting bow, we can see increase of Ranged Damage and in the format not 2x+2, but 2x -> 4x

Image

Another example

Sinew Binding
In the JEI: Flexible IV
In crafting Grid with original bow with Flexible II + binding Flexible IV result bow: Flexible II

commented

So the final item is correct, it's just that the part tooltips can be incorrect. Materials were experiencing a similar issue until recently.

commented

If 2x instead of 2+x is correct, then yes, it's correct.

Final item issues usually related to modded materials, for example, Osmium or Refined Obsidian from Mekanizm.
Is there some sort of config to fix such items or add more?

commented

4x ranged damage on the final gear item would be correct. The "nx" notation used by the ranged damage property might be a little misleading. I had intended to rework it to be more consistent with other properties, but forgot somewhere during the 3-month-long 1.21 porting process lol.

The property modifier not being displayed on the tip upgrade part is most likely a programming error introduced during the 1.21 port. Probably very similar to the issue material tooltips had until recently, but I haven't had a chance to look yet.