Axe missing c:tools/melee_weapon tag
Appulcake opened this issue ยท 2 comments
Versions
- Silent Gear: 4.0.20
- Silent Lib: 10.4.0
- NeoForge: 21.1.172
- Modpack: N/A
- Optifine Installed: No
Quickly made a new MC instance with only SGear (+lib) + a tooltip mod to show tags to make sure no other mod interferes with this, after coming upon this issue when playing in a 1.21 modpack.
For some usages (e.g. apothic reforging) in other mods, silent gear created axes didn't seem to work, so I investigated and found that it lacks a tag that the vanilla MC axe does have.
As seen here, a vanilla axe (tested with a simple diamond axe), has the c:tools/melee_weapon tag (https://i.imgur.com/9hp1wPc.png) while a sgear axe (tested with again a simple diamond axe) doesn't (https://i.imgur.com/3d7ppDp.png). This means other mods might not recognise its hybrid use so that it's not just a harvest tool but also semi-combat tool.
Upon further investigation I also realised the Apotheosis affix/reforge not working on it is not because of the missing tag as it doesn't check it by tag, but that other mod sometimes missing the axe for some reason as having damage making it not accepted as a reforgeable weapon/tool. That can be fixed by a datapack (or config in pre 1.21 versions of that mod) forcing silentgear:axe to be in apotheosis loot table.
Still, not sure if sgear axe not having the c:tools/melee_weapon might cause any issues elsewhere, since vanilla axes have them, so it might be a good addition/fix?
