Silent Gear

Silent Gear

36M Downloads

Executing sgear_mats dump fails when data resource not present (item registered with a silent gem trait but silent gem mod not installed)

Appulcake opened this issue ยท 0 comments

commented

Versions

  • Silent Gear: 4.0.28.1
  • Silent Lib: 10.5.1
  • NeoForge: 21.1.203
  • Modpack: FTB Skies 2 1.9.0

Expected Behavior

Running /sgear_mats dump to successfully output a dump of all materials, instead of coming short and failing with an error.

(Description here)

Actual Behavior

When running /sgear_mats dump, the output/silentgear/material_export.tsv is very incomplete and cut short. This is evident by a set of Error executing task on Client and Failed to process a synchronized task of the payload: silentgear:command_output error messages right after executing it in debug.log, both caused by a Data resource not present: silentgems:booster.

I think this happens because a mod in the pack registers an item with the c:gems/citrine tag, one such occurrence I could find is from Productive Bees (its data/productivebees/recipe/centrifuge/gems/honeycomb_citrine.json has a productivebees:wax as output with the "c:gems/citrine" tag), regardless of the pack even having any mod that adds the citrine gem as item. Then, Silent Gear Metalworks detects that and thinks the item exists, and assigns it a Silent's Gems trait via SGear Metalworks' data/silentgems/silentgear_materials/citrine.json that contains:

    "silentgear:setting": {
      "traits": [
        {
          "conditions": [],
          "level": 1,
          "trait": "silentgems:booster"
        }
      ]
    }

Then, when Silent Gear is iterating through materials and traits and such when running /sgear_mats dump, it comes across this now registered silentgems:booster trait, except it fails because Silent's Gems mod is not present in the modpack.

Logs

Latest.log | Debug.log
Example incomplete mats dump output from output/silentgear: material_export.txt (material_export.tsv renamed to material_export.txt for github upload)

Steps to Reproduce the Problem

  1. Use Silent Gear + Silent Gear Metalworks + any mod that happens to register any item that has a matching tag of a gem that'd be used by Silent's Gems (like Productive Bees, and c:gems/citrine as an example), but don't have Silent's Gems mod
  2. Try to run /sgear_mats dump to export mats list
  3. Exported list stops before exporting everything with an error in debug.log