Improper tools crafted with Iblis installed
darkphan opened this issue ยท 7 comments
Versions
Minecraft Version: 1.12.2
Silent's Gems Version: 2.5.6-236+
Silent Lib Version: 2.2.11-92
Expected behavior
Craft proper tools with supercharged gems.
Actual behaviour
Completely random tools appears to be crafted, including who crafted the tool.
Steps to reproduce the problem
- Install versions of Silent's Gems, listed above. Install Iblis.
- Attempt to craft supercharged tool.
- ...
- Profit (well not really profit :/)
Not quite what I originally thought. It's not the example recipes, the NBT is getting wiped from the crafting output. I don't think I can fix that myself.
What is interesting is if you go back a few versions of Silent Gems and SilentLib the issue does not occur.
I see, 2.5.6 seems fine, but the recipe code was rewritten in 2.5.7 to support CraftTweaker. That must be part of the problem.
Seems like Iblis is changing the priority of recipes somehow. So instead of the "real" recipe, you're crafting the example recipes that exist just for JEI. I should be able to work around the issue on my end, but it might be worth reporting to Iblis as well.
Currently I use wrappedRecipe.getRecipeOutput().copy(). I should use wrappedRecipe.getCraftingResult(InventoryCrafting) instead as input of getCraftingResult() function of wrapped recipe. This should fix issue. I will release fixed version as soon as possible.
https://github.com/Foghrye4/Iblis/blob/MC_1.12/src/main/java/iblis/crafting/PlayerSensitiveShapedRecipeWrapper.java#L39
Looks like everything works now, thanks @Foghrye4!