Silent's Gems

Silent's Gems

Mods
9M Downloads

NBT Errors with Cyclic Workbench and Cyclic Inventory craftingtable

Quostin opened this issue · 4 comments

commented

Versions

Minecraft Version: 1.12.2
Silent's Gems Version: 1.12-2.5.11-250
Silent Lib Version: 1.12-2.2.13-94
Modpack and Version (if applicable): Mech and Magic 1.12.2-RC4

Expected behavior

  • To make the actual tool with the gems selected

Actual behaviour

  • Gives a random tool than what you used.

Steps to reproduce the problem

  1. Use Cyclic Workbench or Cyclic Inventory
  2. Place Gems down as what recipe shows
  3. pulls the Error NBT item into inventory.
  4. Select the new tool...

image

image

Used aquamarine in the examples above, but it does that for all gems using the Cyclic Workbench and Cyclic Inventory.

commented

This most likely needs to be fixed on Cyclic's end.

commented

Cyclic author here, looking into this now.

Is there some sort of onCrafted event I can hook into?

I think this is the offending line, but all it does is grab the output. Unless maybe the .copy() is ignoring NBT?.

https://github.com/PrinceOfAmber/Cyclic/blob/04b525a5ba3a52c86a2f4750f717730e178ecae5/src/main/java/com/lothrazar/cyclicmagic/component/workbench/ContainerWorkBench.java#L63

  • 👍1
commented

@PrinceOfAmber Try using IRecipe#getCraftingResult instead. My recipe needs access to the InventoryCrafting to produce the right output.

This is the recipe class: https://github.com/SilentChaos512/SilentGems/blob/1.12/common/net/silentchaos512/gems/recipe/RecipeMixedMaterialItem.java#L173

commented

Confirmed fixed in latest version of Cyclic.