Silent's Gems

Versions

Silent's Gems: SilentLib-1.15.2-4.6.0+48.jar
Silent Lib: SilentLib-1.15.2-4.6.0+48.jar
Forge: forge-30.0.43
Modpack: Randomly Added Mods v1.9

We've updated our server and added silent gems in the update. We are getting some massive lag spikes.

I've run some profiling that excludes ticks that are finished before 1 second passes and this is the result: https://sparkprofiler.github.io/#jkKxYA5iVq

I was able to fix this by disabling Chaos Slime spawning in 1.14, hope that helps and narrows down the issue

Possibly the same issue as #440. I have no idea how this is happening, I've never encountered anything like it.

…

On Wed, Feb 5, 2020, 10:12 Darkere ***@***.***> wrote: Versions - *Silent's Gems*: SilentLib-1.15.2-4.6.0+48.jar - *Silent Lib*: SilentLib-1.15.2-4.6.0+48.jar - *Forge*: forge-30.0.43 - *Modpack*: Randomly Added Mods v1.9 <https://www.curseforge.com/minecraft/modpacks/randomly-added-mods/files/2875478> We've updated our server and added silent gems in the update. We are getting some massive lag spikes. I've run some profiling that excludes ticks that are finished before 1 second passes and this is the result: https://sparkprofiler.github.io/#jkKxYA5iVq — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#445?email_source=notifications&email_token=ABLU6XIMI24FSCRYHQARFHTRBLQOHA5CNFSM4KQN3F3KYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4ILIFWBA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLU6XICN64HFKA7HSYV25TRBLQOHANCNFSM4KQN3F3A> .

It does seem to be tied to the slime and wisp events. I think the function that hangs is one for getting a chunk from the world. Not sure why it only happens in some cases. Might be worth comparing mod lists in affected instances.

…

On Fri, Feb 7, 2020, 13:38 Partonetrain ***@***.***> wrote: I was able to fix this by disabling Chaos Slime spawning in 1.14, hope that helps and narrows down the issue — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#445?email_source=notifications&email_token=ABLU6XI5OTGP47T7ZUGGCADRBW2CDA5CNFSM4KQN3F3KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELEJGOY#issuecomment-583570235>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABLU6XPRXTJ3WQIDHCUO7TTRBW2CDANCNFSM4KQN3F3A> .

I think I found out what causes the lagspikes.
Here:

SilentGems/src/main/java/net/silentchaos512/gems/world/spawner/CorruptedSlimeSpawner.java

Line 57 in eb445e0

    
           int posY = world.getChunk(posX, posZ).getTopBlockY(Heightmap.Type.WORLD_SURFACE, posX, posZ) + 1;

you are calling world#getChunk with a BlockPos, but getChunk expects a ChunkPos. This causes the server to load a chunk far away, wich causes the lagspikes.
A solution would be to use world.getChunkAt(new BlockPos(posX, 0, posZ)) to get the right chunk.

Share to

Versions