Silent's Mechanisms

Silent's Mechanisms

7M Downloads

Recipes for alloy smelting don't works

Emalios opened this issue ยท 7 comments

commented

Versions

  • KubeJs: 2.7.1.3
  • MixinBootstrap: 1.0.3
  • Silent's Mechanisms: 0.7.6
  • Silent Lib: 4.6.4
  • Forge: 31.2.5
  • Modpack: N/A

Expected Behavior

  • That recipes in silentm/data/recipes/alloy_smelting works

Actual Behavior

  • Recipes in silentm/data/recipes/alloy_smelting don't works

Links/Images

Steps to Reproduce the Problem

  1. Install kubejs and mixinbootstrap
  2. Just look the craft list of alloy smelter
commented

Probably nothing I can do if the issue only occurs with another mod installed. Please provide a log file.

commented

Looks like this needs to be reported to KubeJS. Not sure how that mod works, but it seems like something is intercepting recipes and failing on certain types. I also see errors for Silent Gear recipes in your log. First error is on line 475.

commented

I have find the bug thanks to a friend, in your json recipes, there is a "value": [] to have an array of items but to have an items array you have to write "values" : []

commented

No, it will read the property with either value or values. The alloy smelter recipes in the latest version were created by a data generator. They contain no errors and load correctly without KubeJS installed.

commented

Yes, but here :


You forgot to check if there are more than one ingredients right ?

commented

That function serializes a single ingredient. Ingredients can be multiple items/tags. I changed the preferred name to value because it makes sense. I kept a check for values in the deserialize method for compatibility with existing data packs. I see no issue.