Simple Discord Link Bot

Simple Discord Link Bot

1M Downloads

[Bug]: Advancements are referred to as "achievements" in the messageFormatting config section.

DorkOrc opened this issue ยท 3 comments

commented

๐Ÿž Description

This should be "advancements" and the description should say "Advancement Messages":

[messageFormatting]
	#Achievement Messages. Available variables: %player%, %title%, %description%
	achievements = "..."

The term "achievements" is not used by Minecraft, and having it use the wrong word can make it harder to search for advancement-related settings in the config file.

๐Ÿ”„ Steps to reproduce

  1. Open the default config file
  2. Search for "achievement"

โœ… Expected behavior

It should refer to these messages as "Advancement Messages"

โŒ Actual behavior

Instead, it calls them "Achievement Messages"

๐ŸŽฎ Minecraft Version

1.21.5-pre2

๐Ÿ› ๏ธ Mod Version

SimpleDiscordLink-Universal-3.3.0+snapshot.2

๐Ÿ“ฆ Mod Loader

Fabric

๐Ÿ”ง Mod Loader Version

n/a

๐Ÿ“š CraterLib Version

CraterLib-Fabric-25w10a-2.1.4+experimental.0

๐Ÿ“œ Logs & Screenshots

No response

commented

Stop breaking my config will you ๐Ÿ˜œ.

They used to be called achievements at one point, hence the naming

commented

Hahaha, off I go to find more ways to break the config ๐Ÿ˜‚ /j

commented

Changed in 3.3.0