[Bug]: Having Flan installed causes modded advancements to not be localized
Y1rd opened this issue · 4 comments
🐞 Description
If Flan is installed on a server along side Simple Discord Link, advancements from any mod printed out to discord don't have localization, and display the strings instead.
🔄 Steps to reproduce
- Installed Flan, Simple Discord Link, and any mod that adds additional advancements into the game (e.g. Farmer's Delight)
- Setup a discord bot, add a channel for the bot to send messages
- Launch the server and let any player obtain an modded advancement
- Look in discord chat for unlocalized advancement message
✅ Expected behavior
Advancements should be localized and be read, as seen here:
❌ Actual behavior
Advancements are not localized, instead printing out the string.
🎮 Minecraft Version
1.18.2
🛠️ Mod Version
3.2.3
📦 Mod Loader
Forge
🔧 Mod Loader Version
40.3.9
📚 CraterLib Version
2.1.4
📜 Logs & Screenshots
Sadly, not much I can do about this. The mod relies on the data given to it by the game, and if something breaks that, it breaks the mod too.
In these cases, the advancements won't show up correctly in the console either.
It doesn't affect the client side, because the client actually has the language files containing the text on it, whereas the server usually doesn't.
This is a problem for all discord mods as far as I know
Sadly, not much I can do about this. The mod relies on the data given to it by the game, and if something breaks that, it breaks the mod too.
In these cases, the advancements won't show up correctly in the console either.
It doesn't affect the client side, because the client actually has the language files containing the text on it, whereas the server usually doesn't.
This is a problem for all discord mods as far as I know
Yikes, I originally thought a different discord mod was just not working with modded advancements, but I turned out wrong after digging a bit deeper after it was happening here as well. None of my other 190 mods in my pack break this.
I guess I will be forwarding this issue to the author of Flan, thanks for looking at it!
Yikes, I originally thought a different discord mod was just not working with modded advancements
They usually do, and so do ours, but there are these weird cases of things somehow breaking the language support on servers. Only real solution to this, is to force the mod to be both client and server side, and then each time something fails, we ask the client for the correct information, but, who wants a discord server mod to be a requirement client side?