TemptGoal Crash in 1.16.4

Question

TemptGoal Crash in 1.16.4

alexnmt opened this issue 4 years ago · 25 comments

alexnmt commented 4 years ago

Forge 35.1.12

Had this crash a couple of times. It looks like it's a simple farming bug, though forgive me if it's not. The first time it happened it was while flying around in one world. The most recent time, it was on world load of a different world.

`---- Minecraft Crash Report ----
// Sorry :(

Time: 23/12/20 08:55
Description: Exception in server tick loop

java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Unsupported mob type for TemptGoal
at java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:273) ~[?:1.8.0_242] {}
at java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:280) ~[?:1.8.0_242] {}
at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:618) ~[?:1.8.0_242] {}
at java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:591) ~[?:1.8.0_242] {}
at java.util.concurrent.CompletableFuture$Completion.run(CompletableFuture.java:456) ~[?:1.8.0_242] {}
at net.minecraft.world.chunk.ChunkTaskPriorityQueueSorter.func_219083_b(SourceFile:58) ~[?:?] {re:classloading}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213166_h(ThreadTaskExecutor.java:172) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.world.server.ServerChunkProvider$ChunkExecutor.func_213166_h(SourceFile:545) ~[?:?] {re:classloading}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213168_p(ThreadTaskExecutor.java:134) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.world.server.ServerChunkProvider$ChunkExecutor.func_213168_p(SourceFile:554) ~[?:?] {re:classloading}
at net.minecraft.world.server.ServerChunkProvider.func_217234_d(SourceFile:280) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B}
at net.minecraft.server.MinecraftServer.func_213205_aW(MinecraftServer.java:721) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftServerAccessor,pl:mixin:A}
at net.minecraft.server.MinecraftServer.func_213168_p(MinecraftServer.java:710) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftServerAccessor,pl:mixin:A}
at net.minecraft.util.concurrent.ThreadTaskExecutor.func_213161_c(ThreadTaskExecutor.java:150) ~[?:?] {re:computing_frames,pl:accesstransformer:B,re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at net.minecraft.server.MinecraftServer.func_213202_o(MinecraftServer.java:696) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftServerAccessor,pl:mixin:A}
at net.minecraft.server.MinecraftServer.func_240802_v_(MinecraftServer.java:645) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftServerAccessor,pl:mixin:A}
at net.minecraft.server.MinecraftServer.lambda$startServer$0(MinecraftServer.java:232) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:accessor.MinecraftServerAccessor,pl:mixin:A}
at java.lang.Thread.run(Thread.java:748) [?:1.8.0_242] {}
Caused by: java.lang.IllegalArgumentException: Unsupported mob type for TemptGoal
at net.minecraft.entity.ai.goal.TemptGoal.(SourceFile:40) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:quark.mixins.json:TemptGoalMixin,pl:mixin:A}
at enemeez.simplefarming.entities.ai.MoreTemptation.(MoreTemptation.java:9) ~[simplefarming:1.16.4-1.3.5] {re:classloading}
at enemeez.simplefarming.events.TemptationTask.onEntitySpawn(TemptationTask.java:33) ~[simplefarming:1.16.4-1.3.5] {re:classloading}
at net.minecraftforge.eventbus.ASMEventHandler_983_TemptationTask_onEntitySpawn_EntityJoinWorldEvent.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-3.0.5-service.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:297) ~[eventbus-3.0.5-service.jar:?] {}
at net.minecraft.world.server.ServerWorld.func_217440_f(ServerWorld.java:829) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:charm.mixins.json:ServerWorldMixin,pl:mixin:APP:charm.mixins.json:accessor.ServerWorldAccessor,pl:mixin:APP:quark.mixins.json:ServerWorldMixin,pl:mixin:A}
at net.minecraft.world.server.ChunkManager.lambda$null$25(ChunkManager.java:763) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at com.mojang.datafixers.util.Either.lambda$mapLeft$0(Either.java:162) ~[datafixerupper-4.0.26.jar:?] {re:classloading}
at com.mojang.datafixers.util.Either$Left.map(Either.java:38) ~[datafixerupper-4.0.26.jar:?] {}
at com.mojang.datafixers.util.Either.mapLeft(Either.java:162) ~[datafixerupper-4.0.26.jar:?] {re:classloading}
at net.minecraft.world.server.ChunkManager.lambda$func_219200_b$26(ChunkManager.java:733) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:OptiFine:default}
at java.util.concurrent.CompletableFuture.uniApply(CompletableFuture.java:616) ~[?:1.8.0_242] {}
... 15 more

A detailed walkthrough of the error, its code path and all known details is as follows:

stevojhall · Answer 1 · 2021-01-03T15:05:22.000Z

I seem to also be getting this temptgoal crash although my crash log is different, I can create a new issue if you like but thought it maybe relevant crash.

https://pastebin.com/ztb8czem

EternalShadow17 · Answer 2 · 2021-01-04T20:00:38.000Z

does it do it if you remove optifine?

EternalShadow17 · Answer 3 · 2021-01-05T15:07:58.000Z

Crash reports mention quark and apotheosis, temptgoal mean its trying to lure an animal with food and its failing. Id disable all mods just keep sf and add mods slowly to try them out, start with mob mods obviously, id say try just sf and quark first

stevojhall · Answer 4 · 2021-01-05T12:19:20.000Z

still happens, don't know if that's a good sign or bad lol

https://pastebin.com/Wf1b1vdP

Edit: dont know if it helps but its crashing as I approach a tower from I think Valhesia structures and its possible that the mob is a Vex (only mob that the tower can spawn that I haven't encountered yet)

stevojhall · Answer 5 · 2021-01-05T15:51:56.000Z

I rechecked my inv on my save and there is no simple foods on me at the time of the crash, which means the crash was caused environmentally (maybe a mod causing seeds/food on the ground to be tempting). i will try to reproduce with just these 3 mods in diff combinations but leaning maybe towards apotheosis based on the below from the log

Stacktrace:
at net.minecraft.entity.ai.goal.TemptGoal.(SourceFile:40) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,xf:fml:apotheosis:apothtempting,pl:mixin:APP:quark.mixins.json:TemptGoalMixin,pl:mixin:A}

alexnmt · Answer 6 · 2021-01-05T16:18:46.000Z

I haven't had the chance to test anything yet, but I don't have apotheosis installed, so I don't think it would be that exclusively.

my Java knowledge is very very limited, but looking through the mod code and my crash report, it seemed to be related to something in the entities/ai/MoreTemptation.java and events/TemptationTask.java where it references specifically chickens and the seeds that work to tempt them. That pointer is there in both mine and your crash reports

at enemeez.simplefarming.entities.ai.MoreTemptation.(MoreTemptation.java:9) ~[simplefarming:1.16.4-1.3.5] {re:classloading} at enemeez.simplefarming.events.TemptationTask.onEntitySpawn(TemptationTask.java:33) ~[simplefarming:1.16.4-1.3.5] {re:classloading}

Could it have something to do with a new type of chicken mob that is added? There aren't a ton of relevant mods that both of us are using so maybe that's a place to start. We both have Alex's mobs - it's a new mod so I'm sure there are plenty of bugs. Perhaps one of the birds could be a modified chicken? Could be Quark as already suggested. Maybe it's something that adds other seeds, such as farmer's delight. I suppose it could be AI Improvements if that is messing with the AI...

stevojhall · Answer 7 · 2021-01-06T06:33:45.000Z

So I tried loading my save without alexsmobs and going towards the area that consistently crashed (like 7 or 8 times in a row) and I can get right up to the tower which I couldn't do before, I will set up a test pack with just alexsmobs and simplefarming using the same forge version as the modified Enigmatica 6 modpack im running to see if I get some results.

If I can reproduce the crash with just alexsmobs and simplefarming ill link the crash to their issue tracker as well.

NielsPilgaard · Answer 8 · 2021-01-08T20:55:34.000Z

@stevojhall Any update? :)

alexnmt · Answer 9 · 2021-01-08T21:46:39.000Z

I've not managed to test yet as I've been busy, but will do this weekend. It wouldn't totally surprise me if it was Alex's mobs. I love his mods but they are a bit buggy. I had to take I&F out of my modpack for the time being because there were some bugs that have needed fixing from a few versions ago.

@NillerMedDild I saw that other post and it mentioned an alligator. In one of the worlds I was in that had this crash, there was definitely an alligator near by in the swamp biome I was testing, so that seems like more evidence pointing to Alex's Mobs...

stevojhall · Answer 10 · 2021-01-09T06:43:23.000Z

ive done some initial tests with just alexs mod and simplefarming and no crash on its own, removed alexs mod from enigmatica 6 and it allowed me to get further without crashing. i have almost finished setting up a testing area where i drop food onto mobs or mobs that can be eaten by mobs. work unfortunately has gotten in the way. i will update with full results

…

On Fri, 8 Jan 2021 at 21:46, alexnmt ***@***.***> wrote: I've not managed to test yet as I've been busy, but will do this weekend. It wouldn't totally surprise me if it was Alex's mobs. I love his mods but they are a bit buggy. I had to take I&F out of my modpack for the time being because there were some bugs that have needed fixing from a few versions ago. @NillerMedDild <https://github.com/NillerMedDild> I saw that other post and it mentioned an alligator. In one of the worlds I was in that had this crash, there was definitely an alligator near by in the swamp biome I was testing, so that seems like more evidence pointing to Alex's Mobs... — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#128 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AF7BWCGN6A4EECXW5VAD32LSY54M3ANCNFSM4VGXHVOQ> .

coderepo8593 · Answer 11 · 2021-01-25T01:27:31.000Z

I am getting this same crash as well, and I am also using Alex's mobs.

Not too sure if you have an official bug tracker, but I am having a crash when entering a chunk that has a Valhelsia sructure and horses. Don't know if those have anything to do with the error or not. You can see two other posts on the internet with the same problem.

https://www.reddit.com/r/FeedTheBeastCrashes/comments/kldamu/crash_just_happened_shortly_after_i_started_a/

https://www.minecraftforum.net/forums/support/java-edition-support/3044318-crash-entering-specific-area

Here's the relevant portion of my crash report.

-- Head --
Thread: Server thread
Stacktrace:
at net.minecraft.entity.ai.goal.TemptGoal.(SourceFile:40) ~[?:?] {re:mixin,pl:accesstransformer:B,re:classloading,pl:accesstransformer:B,pl:mixin:APP:quark.mixins.json:TemptGoalMixin,pl:mixin:A}
at enemeez.simplefarming.entities.ai.MoreTemptation.(MoreTemptation.java:9) ~[?:1.16.4-1.3.5] {re:classloading}
at enemeez.simplefarming.events.TemptationTask.onEntitySpawn(TemptationTask.java:33) ~[?:1.16.4-1.3.5] {re:classloading}
at net.minecraftforge.eventbus.ASMEventHandler_403_TemptationTask_onEntitySpawn_EntityJoinWorldEvent.invoke(.dynamic) ~[?:?] {}
at net.minecraftforge.eventbus.ASMEventHandler.invoke(ASMEventHandler.java:85) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus$$Lambda$2121/1825536232.invoke(Unknown Source) ~[?:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:302) ~[eventbus-4.0.0.jar:?] {}
at net.minecraftforge.eventbus.EventBus.post(EventBus.java:283) ~[eventbus-4.0.0.jar:?] {}

coderepo8593 · Answer 12 · 2021-01-25T04:09:49.000Z

@wchen1990

I tried your PR fix in 1.16 but I still get the error in the same place. It happens both when using the existing world where it crashes right away because I am in the chunk with the faulty mob, and also in my backup when I go to the chunk where it occurs.

stevojhall · Answer 13 · 2021-01-25T10:13:01.000Z

although it was happening for me when approaching a Valhesia structure I don't believe it adds new mobs (it was a tower with spawners) removing alexs mobs allowed me to approach the structure without crashing whereas it was crashing 100% of the time I approached before, OP doesn't seem to have Valhesia structures.

coderepo8593 · Answer 14 · 2021-01-25T20:06:29.000Z

@stevojhall

The difficulty I am having is that I can't reproduce the bug now, and using wchen1990's PR fix didn't have an effect when I could.

The problem is that I don't see anywhere in Alex's mobs where he inherits from or defines a PigEntity, ChickenEntity, CowEntity, or SheepEntity, which is what would be required for the instanceOf check to be matched and the temptation goal to be added.

The only way this could be happening with Alex's mobs is if registering your animal entity with Forge somehow causes it to be casted to one of these types for it's internal purposes for interoperability among mods. For instance, if for compatability purposes with another mod it made sense to make it think your mob was a PigEntity. The thing is, this is purely conjecture and I don't think Forge does this, unless it's doing some kind of dependency injection with the interfaces, which I also don't believe it is doing either.

So, if Alex's mobs is causing this problem, I don't know how since the code that is causing it requires one of those 4 entities to be spawned.

EDIT:
Oh and also, how do you know it's simply not spawning a different entity now instead of another one, thus no longer causing the error?

In my instance, it is in a Sunflower Biome. For Alex's mobs that would be hummingbirds. However, I have seen hummingbirds before multiple times without experiencing the bug. Is there anything else that spawns which is unique to Sunfllower Biome's?

wchen1990 · Answer 15 · 2021-01-25T20:23:49.000Z

@coderepo8593 Funny you mention Alex's Mobs, since that's exactly the thing that prompted to make my PR.

I'm a bit surprised that when you checked out and built my branch it didn't solve the issue for you. Are you sure you were using the correct jar when you built my branch? Even if you did use my branch you would at least get a different line number in the crash report.

The only other possibility I can see is if the entity that it was trying to cast was null and that's where the null pointer exception came from.

As an aside, I also tried to see what it was that Alex's Mob was doing that could've caused this and I couldn't find anything as well.

Edit: In my cause the thing that was crashing me was a SheepEntity, and when the chunk finally loaded after my fix there was in fact a Sheep there. I guess another possibility would be that when adding the AI the entity hasn't had a navigator instantiated yet? But, I'm not sure how plausible that is since I haven't actually checked.

coderepo8593 · Answer 16 · 2021-01-25T21:39:39.000Z

@wchen1990 I think you are correct that I could have used the wrong jar. So far I have done a few more test runs and it only happens on the jar without your fix. However, I haven't been able to reliably reproduce the error.

EDIT: Yeah, the problem with blaming Alex's mobs is that nearly everyone is going to have it in their modlist. So it is could be purely coincidental that everyone who has posted their logs online has it installed.

Darianna77 · Answer 17 · 2021-01-26T12:19:03.000Z

Mhh i have that crash too (Enigmatica 6 Pack) Where can i get this fix thats mentioned here...a PR Fix from you @wchen1990 ?
I was unable to get back in my world...have disable for testing the Simple Farming Mod And then i could load the world. but i will load it back in

wchen1990 · Answer 18 · 2021-01-26T15:49:40.000Z

@Darianna77 you can checkout my PR (#139) for simplefarming and use it to build a jar. If you don't know how to you can find the resources online pretty easily, but essentially you need to have the Java JDK installed and then in the directory you have all of the source files you just run gradle build.

Hopefully, @cweckerl will merge the PR and make a release so that it'll be easier for people to just get the latest version with the fix.

coderepo8593 · Answer 19 · 2021-01-26T18:58:08.000Z

@Darianna77

PR fix to restrict by ground and flying navigator

Here is a link to the jar file that I built. Hopefully we can get some more people testing this.

BlueStarBRS · Answer 20 · 2021-02-03T02:05:36.000Z

same problem here i can not load it

FabrizioMFE · Answer 21 · 2021-02-22T00:46:25.000Z

Any updates on a fix for this issue?

anagram3k · Answer 22 · 2021-02-22T00:56:27.000Z

The build from @coderepo8593 fixes the problem for me

FabrizioMFE · Answer 23 · 2021-02-22T02:06:13.000Z

The build from @coderepo8593 fixes the problem for me

Same, that jar does seem to fix the issue though I don't see the PR he's talking about but it'd be nice if it was added to the main mod at some point.

anagram3k · Answer 24 · 2021-02-22T03:39:47.000Z

The build from @coderepo8593 fixes the problem for me

Same, that jar does seem to fix the issue though I don't see the PR he's talking about but it'd be nice if it was added to the main mod at some point.

The merge request is here: #139

Mysteryem · Answer 25 · 2021-07-14T22:58:40.000Z

The issue here comes from the fact that getNavigator() returns the Navigator of the MobEntity being ridden if there is one. In TemptGoal's constructor it calls getNavigator() and ends up checking the Navigator of the ridden entity instead of the entity passed into the constructor.

In my case I was using a different mod that adds TemptGoal subclasses in a similar way in the EntityJoinWorldEvent. Alex's Mobs was causing the crash to happen, but it's not to blame for the crash. Crocodiles force entities to ride them when they attack them and they have a custom SemiAquaticPathNavigator when in water. I found that a pig riding the crocodile was causing my crash. Presumably, the chunk got unloaded before the crocodile managed to kill the pig and then whenever the chunk got loaded again it crashed the server.

Share to

A detailed walkthrough of the error, its code path and all known details is as follows: