Simple Planes (Forge)

Simple Planes (Forge)

Mods
7M Downloads

Modded Water Detection

rhino1998 opened this issue ยท 0 comments

commented

Planes do not detect some modded fluids properly. For instance, TerraFirmaCraft flowing water and salt water are both not recognized properly causing planes to not float on their surface or be impeded by the fluid at all. It is possible to fly a plane through a TFC ocean.

It looks like the following checks are looking specifically for vanilla minecraft water rather than general fluids.

simple-planes/src/main/java/xyz/przemyk/simpleplanes/upgrades/floating/FloatingUpgrade.java

Line 26 in 9581a61

if (planeEntity.level.getBlockState(new BlockPos(planeEntity.position().add(0, 0.5, 0))).getBlock() == Blocks.WATER) {

simple-planes/src/main/java/xyz/przemyk/simpleplanes/entities/PlaneEntity.java

Lines 994 to 996 in 9581a61

public boolean isOnWater() {
return level.getBlockState(new BlockPos(position().add(0, 0.4, 0))).getBlock() == Blocks.WATER;
}