Simple Planes (Forge)

Simple Planes (Forge)

5M Downloads

Crashes specifically with Create Fabric

Skaytacium opened this issue · 4 comments

commented

If the fabric branch is sitll unmaintained then please close this, I saw activity from the past week on it so I thought that it is still in development or has continued development.

I was trying to play simple planes with create and every time the world joining screen got to 100% it crashed before it joined the world and these were the reports. They both work fine individually and since simple planes seems to be in development for 1.19.2 I thought I'd just report a bug. The error logs also showed simpleplanes and since I'm not a mod developer I thought this might be the issue.

There are no other mod conflicts that I can see and it works well with everything else when without create. Its amazing that a fabric port for 1.19.2 is being developed (hopefully). The crash logs have most of the information that anyone should need and if any more is required I will gladly provide it.

crash-2023-02-28_00.41.34-server.txt
crash-2023-02-28_00.44.57-server.txt
crash-2023-02-28_02.04.29-server.txt

commented

I'm aware of this bug and have problems testing things with create in a development environment. The development isn't focused on the fabric port, I just work on it every now and then.

commented

Oh that's understandable. I might be able to open a PR and see if I can fix anything in a few days.

commented

The cause is the Overwrite mixin here which is a big no. Overwrite mixins breaks other mixins very easily and are incompatible with other mods

public static List<EnchantmentInstance> getAvailableEnchantmentResults(int i, ItemStack itemStack, boolean bl) {

Someone came to me saying my Bumblezone mod crashed. Looked at log and Simple Plane’s overwrite mixin broke my enchantment mixins I tried to make carefully to be compatible with other mods.
https://controlc.com/9b521abd

When you go back to working a bit on Fabric, you can replace your mixin with something like this or use Porting Lib. You are free to use my enchantment mixin code for your mod regardless of my license to help deal with incompat easier
https://github.com/TelepathicGrunt/Bumblezone/blob/1.19.2-Fabric/src/main/java/com/telepathicgrunt/the_bumblezone/mixin/enchantments/EnchantmentHelperMixin.java

commented

I have the same problem in minecraft1.19.2Fabric