Unsafe cast crashes with Create

Question

Unsafe cast crashes with Create

TropheusJ opened this issue 2 years ago · 6 comments

TropheusJ commented 2 years ago

This line is not safe and you should use instanceof instead. This causes a crash with Create: Fabricators-of-Create/Create#643

Pinaz993 · Answer 1 · 2022-12-28T16:47:07.000Z

Changes are live on CF.

Pinaz993 · Answer 2 · 2022-12-28T15:35:25.000Z

That is interesting. I'll make the change, but I'm curious as to why this crashes with Create, when nothing else seems to care.

Pinaz993 · Answer 3 · 2022-12-28T16:09:52.000Z

Change made in 1.17, 1.18, and master.

TropheusJ · Answer 4 · 2022-12-28T21:31:16.000Z

Thanks! This crash happens because when schematics are loaded, they use structures to be placed into the fake schematic world. During structure loading, the block entity will be loaded and marked as dirty, where this cast happens, causing the crash.

Pinaz993 · Answer 5 · 2022-12-31T15:43:56.000Z

The fact that structures use a subclass of World that crash on isClient() is very strange. Very strange indeed.

Pinaz993 · Answer 6 · 2023-01-04T17:39:50.000Z

Thanks! This crash happens because when schematics are loaded, they use structures to be placed into the fake schematic world. During structure loading, the block entity will be loaded and marked as dirty, where this cast happens, causing the crash.

Also, thanks for taking the time to narrow this down instead of just dumping it on me. It was really helpful and made this much quicker to fix.

Share to