Simple Storage Network

Simple Storage Network

56M Downloads

Storage Request Table messes up inventory order

bytebone opened this issue ยท 13 comments

commented

Minecraft version & Mod Version: 1.12.2 / 1.7.4

Single player or Server: Server

Describe problem (what you were doing / what happened): When opening the Storage Request Table, it will reorder all the items in my inventory by pushing them one slot to the right. This is purely visual, clicking on any item will reset the display.

Here is a gif of the issue: https://imgur.com/OSomjLC

Crash log (if any): no crashing

commented

we've had a similar issue on our server (noted by duely below) did you happen to upgrade your version on the same world? the issue sounds exactly the same. generating a new world, and we couldn't replicate the issue. Wonder if this has anything to do with it??

Really looking forward to this mod being updated. Please Lothrazaar?

commented

Yes, we upgraded the mod on an existing map (upgrading from 1.5.7). I haven't tried creating a new map on the new version.

commented

I'm having this same issue also on a recently made server. We previously had 1.7.4 but hadn't had a storage system yet made anywhere at all. But I had recently gotten us to update to 1.7.5 this morning as twitch launcher was showing me mod updates and I like to keep things up to date. I had just made a storage system, happy that I shouldn't have anymore hoarding and sorting issues anymore and then I notice this bug happening.

it's just as the picture from rainer shows, when I open the requester my inventory is shifted one square sideways for all slots. it seems to react fine when putting stuff in and work such as how I've been emptying all our chests into it by carrying them to the system, breaking them then mass importing stuff through the screen.
but the issue comes when taking stuff out and placing them into the inventory manually as when I leave the screen I must click something in my inventory to make it all snap back to it's original spot, which if that happens it can cause some phantom item visuals etc or some heart attacks with items being yeeted into bugland. :V

commented

I can further confirm that this doesn't happen in a new world. I didn't have a new world with a previous version to test singleplayer having the mod updated half way through so thats still unsure if it's a server thing. but feels like some kind of weird saving issue between versions... I'm just gonna back up and attempt to remove the mod, load, then add the mod back in and rebuild my network with cheats since theres no cells to take forever to empty out into actual inventories... and then if it works, remember not to update till theres more news on this.

Edit: A development!
I played around for a moment before switching out and just found that the wireless remote access doesn't screw the inventory like accessing the system directly. I'm not sure what gives. but thats what it's doing. so it's specifically something to do with the storage screen/crafting interface attached to the system itself that does something different to the remote who's screen looks practically identical.

Edit 2: and for the double combo!
I seems that in my console on the client I'm having these big red fatal pop-ups that go as so:

Error executing task java.util.concurrent.ExecutionException: java.lang.IndexOutOfBoundsException: Index: 45, Size: 45 at java.util.concurrent.FutureTask.report(FutureTask.java:122) at java.util.concurrent.FutureTask.get(FutureTask.java:192) at net.minecraft.util.Util.func_181617_a(Util.java:48) at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1088) at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:398) at net.minecraft.client.main.Main.main(SourceFile:123) at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.lang.reflect.Method.invoke(Method.java:497) at net.minecraft.launchwrapper.Launch.launch(Launch.java:135) at net.minecraft.launchwrapper.Launch.main(Launch.java:28) Caused by: java.lang.IndexOutOfBoundsException: Index: 45, Size: 45 at java.util.ArrayList.rangeCheck(ArrayList.java:653) at java.util.ArrayList.get(ArrayList.java:429) at net.minecraft.inventory.Container.func_75139_a(Container.java:120) at net.minecraft.inventory.Container.func_190896_a(Container.java:527) at net.minecraft.client.network.NetHandlerPlayClient.func_147241_a(NetHandlerPlayClient.java:1191) at net.minecraft.network.play.server.SPacketWindowItems.func_148833_a(SourceFile:50) at net.minecraft.network.play.server.SPacketWindowItems.func_148833_a(SourceFile:12) at net.minecraft.network.PacketThreadUtil$1.run(PacketThreadUtil.java:20) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at net.minecraft.util.Util.func_181617_a(Util.java:47) ... 9 more

Just a whole bunch of them from me tinkering with the system.
image

commented

Can confirm this, but my experience is really different from what others say.
New server with newly created world, and this happens. It is not limited to visuals, it also changes how the request table works.
imagen
Inventory is shifted by one space. The first space of the crafting grid is the output. It doesn't show the output, but if you click there, it gives you it.
The first space on the player inventory is part of the crafting grid. If you put any item there (Like in the next example), you get the normal output:
If you put a piece of iron in this space
You get 9 iron ingots
The normal output slot seems completely nonfunctional.

commented

Do you have FastWorkbench installed? I cant replicate any of these issues in the latest releaes release
ssss

commented

No, I don't have FastWorkbench.
I can confirm it happens, tested it on a newly created server right now with default settings, only Simple Storage Network and forge, and it happens.
Logs here:
https://gist.github.com/AfterRebelion/6d3ce8053f5497789fe8bebec3b062b9

All those "IndexOutOfBoundsException" seem to indicate something...

commented

Tested 1.7.6, and it seems to work as expected now.

commented

#179 has it happneing as well, with a mod list and images

commented

noticed your latest log has MinecraftForge v14.23.5.2838 , im still on
14.23.5.2768 , not sure if its related but maybe

Trying to replicate now on a new install

commented

@AfterRebelion does it only happen on a dedicated server? or also single player

My single player test does not see the index out of bounds or the shift
new install 179

commented

This is dedicated server only, on singleplayer it works fine.