Simple Storage Network

Simple Storage Network

56M Downloads

Golden Lasso

red360 opened this issue ยท 3 comments

commented

Crafting golden lassos do not require XP.

commented

Thanks for your patience i couldnt respond right away

Looks like Golden lasso from EXu2 registers its recipe as a vanilla recipe type. So of course storage network sees that and works with it.

Non vanilla recipes are things like custom Solderer from RS or furnace recipes. so to me it SEEMS like its on the other mods end to fix?

Speaking of RS i guess I can test if their system crafts it

commented

Note to self: Source code for that items recipe
https://github.com/rwtema/Extra-Utilities-2-Source/blob/846a0a59f603c4a60f02d3a6fedc4e468e4ea229/1.10.2/src/main/java/com/rwtema/extrautils2/backend/entries/XU2Entries.java#L490

Its base class has a "finishedCrafting" that drains the exp, but this is not a valid part of the vanilla interface, in other words, does not exist in standard "IRecipe"
https://github.com/rwtema/Extra-Utilities-2-Source/blob/ff6b75ebc334ee0f1a2c2d1fd1394f8d7e4da0bb/1.10.2/src/main/java/com/rwtema/extrautils2/crafting/EnchantRecipe.java#L48
HOWEVER: when i search, i dont see any code actually.... calling/executing this? https://github.com/rwtema/Extra-Utilities-2-Source/search?q=finishedCrafting&unscoped_q=finishedCrafting

Possible solutions

  • IRecipe: getCraftingResult
  • Fire off the event "ItemCraftedEvent" - appears to be removed in 1.12
commented

The other mod appears to be not maintained anymore so this does not seem worth the effort anymore