Client Crashes When Other Player Talks

Question

Client Crashes When Other Player Talks

IAmSneak opened this issue 3 years ago · 36 comments

IAmSneak commented 3 years ago

Client crashes when player around them starts talking with the player that is muted or not talking. This doesn't happen every time. According to the other players on my server, it usually happens after talking for a few mins and its in pauses.

Steps to reproduce the issue

Talk to someone to a little while while they have the mod active (either muted, not talking, or talking).
Have a brief break from talking to them (15 seconds maybe).
Sometimes crashes (inconsistently)

Expected behavior
Talks without crashing

Log files
2021-04-22-7.log.gz

Versions

1.16.4
Fabric loader 0.11.3
Fabric Api 0.32.5
Voicechat 1.1.5

Other mods
Many mods are being used but here are ones that have a chance of causing the issue:
carpet mod
krypton
lithium
sodium
starlight

**Config**

port=24454
bind_address=0.0.0.0
sample_rate=16000
voice_fade_distance=24.0
voice_distance=64.0
codec=VOIP
keep_alive=1000
mtu_size=900

crash-ip21 · Answer 1 · 2021-05-15T19:56:37.000Z

@henkelmax
Okay, sorry didn't got back to you earlier. We've been playing with the version 1.3.10 since it was released, and didn't have any crashes! Thanks again for fixing an issue

henkelmax · Answer 2 · 2021-05-15T21:20:55.000Z

No problem :)

henkelmax · Answer 3 · 2021-04-23T06:43:33.000Z

Does this also happen without any other mods?
There are a lot of OpenGL errors in your logs. I'm assuming, that they are not caused by the voice chat.
Also please update to the latest mod version.

henkelmax · Answer 4 · 2021-04-25T06:48:32.000Z

Please try if it happens without these mods.

Alkiasan · Answer 5 · 2021-04-25T03:18:15.000Z

Having the same issue as a random crash. Also running Carpet, Krypton, and Lithium, but not Sodium/starlight.
Crash seems to be relating to this particular part of the log:
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: java.lang.Error: Invalid memory access
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at com.sun.jna.Native.invokeInt(Native Method)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at com.sun.jna.Function.invoke(Function.java:426)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at com.sun.jna.Function.invoke(Function.java:361)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at com.sun.jna.Library$Handler.invoke(Library.java:265)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at com.sun.proxy.$Proxy88.opus_decode(Unknown Source)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at de.maxhenkel.voicechat.voice.common.OpusDecoder.decode(OpusDecoder.java:36)
[04:09:40] [AudioChannelThread-ba361218-7dd8-4bc0-9bfb-576c6aece479/INFO]: [STDERR]: at de.maxhenkel.voicechat.voice.client.AudioChannel.run(AudioChannel.java:142)

IAmSneak · Answer 6 · 2021-04-28T23:48:09.000Z

It is quite hard to consistently reproduce. I am able to confirm it can crash with just carpet, lithium, and krypton on the server.

henkelmax · Answer 7 · 2021-04-29T06:23:58.000Z

Can you narrow down the mod to a single mod?

Alkiasan · Answer 8 · 2021-04-29T17:24:21.000Z

Krypton's optimisations focus on the net stack. It might be worth checking to see if any of the optimisations krypton makes would effect the voice chat mod?

henkelmax · Answer 9 · 2021-04-29T18:53:03.000Z

It should not affect it, since the voicechat mod does not use minecrafts networking.

Alkiasan · Answer 10 · 2021-04-29T19:03:21.000Z

Actually, come to think of it, the crash is a clientside crash, so it would be weird if these serverside mods are causing it, since I don't have them installed clientside...

Alkiasan · Answer 11 · 2021-04-29T19:03:48.000Z

IAmSneak, What clientside mods do you have installed?
Maybe we can compare and look at the similarities?

henkelmax · Answer 12 · 2021-04-29T19:43:56.000Z

@IAmSneak @Alkiasan Please try the latest version of the mod. I fixed another bug and it might be related to this.

Alkiasan · Answer 13 · 2021-04-30T02:21:26.000Z

Installed the latest version on server and client, sadly, issue still persists.

henkelmax · Answer 14 · 2021-04-30T06:02:45.000Z

Alright, thank you for testing it.
Can you send me the logs of the crash with the latest version?
It would also be great to narrow down the problem to a single mod.

Alkiasan · Answer 15 · 2021-05-01T01:05:31.000Z

no error this time. Final line was
[03:20:49] [VoiceChatClientThread/INFO]: Initializing Opus decoder with sample rate 48000 Hz, frame size 1920 bytes and max payload size 1024 bytes
Log cuts off there.
No crash log generated.

henkelmax · Answer 16 · 2021-05-01T07:27:05.000Z

Great, does this mean it works now?

Alkiasan · Answer 17 · 2021-05-01T17:04:15.000Z

2021-04-30-3.log

Alkiasan · Answer 18 · 2021-05-01T17:04:37.000Z

From the logs folder.
A crash log isn't generated.
This isn't edited. Scroll down and you'll see it just stops.

henkelmax · Answer 19 · 2021-05-01T17:41:43.000Z

Yes, but I can assume what causes it, with the last log entry.

What OS are you using?

Alkiasan · Answer 20 · 2021-05-01T10:21:28.000Z

No, the error just doesn't appear in the log anymore. The crash still happens.

…

On Sat, 1 May 2021, 08:27 Max Henkel, ***@***.***> wrote: Great, does this mean it works now? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#163 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AO6P7OJWRKNE7ZYXZQMFQELTLOUNNANCNFSM43NZWIWA> .

henkelmax · Answer 21 · 2021-05-01T11:41:57.000Z

If it crashes, it has to be in the logs, please send me the logs.

henkelmax · Answer 22 · 2021-05-02T07:07:45.000Z

It would be nice if you could narrow down the mods you are using. If I know which mod is causing it I can reproduce it.

Alkiasan · Answer 23 · 2021-05-01T22:57:12.000Z

Windows 10

Alkiasan · Answer 24 · 2021-05-02T18:45:49.000Z

It's already been narrowed down to three by IAmSneak, and judging from what you said, it can't be Krypton, So it's either Lithium or Carpet causing it.

henkelmax · Answer 25 · 2021-05-02T18:52:11.000Z

Ok, then just test it which mod exactly causes it.

henkelmax · Answer 26 · 2021-05-07T12:59:23.000Z

Any update on this?

crash-ip21 · Answer 27 · 2021-05-07T15:36:30.000Z

Can confirm the issue, experiencing random crashes when talking to another person in a group.
Experienced a crash just few minutes ago, latest.log sadly doesn't have information about that crash.
There are few last lines:

[20:18:06] [VoiceChatClientThread/INFO]: Initializing Opus decoder with sample rate 48000 Hz, frame size 1920 bytes and max payload size 1024 bytes
[20:20:03] [main/INFO]: [CHAT] [Debug]: Hitboxes: hidden
[20:24:00] [main/WARN]: Block entity invalid: minecraft:chest @ class_2338{x=712, y=137, z=-1199}
[20:24:08] [main/WARN]: Block entity invalid: minecraft:chest @ class_2338{x=714, y=137, z=-1201}
[20:26:53] [main/WARN]: Block entity invalid: minecraft:chest @ class_2338{x=706, y=93, z=-1204}
[20:26:58] [main/WARN]: Block entity invalid: minecraft:ender_chest @ class_2338{x=706, y=93, z=-1205}
[20:29:40] [VoiceChatClientThread/INFO]: Initializing Opus decoder with sample rate 48000 Hz, frame size 1920 bytes and max payload size 1024 bytes
[20:30:01] [main/INFO]: [CHAT] [Server: Saved the game]
[20:30:38] [main/INFO]: [CHAT] [Debug]: Hitboxes: shown

Crash happened at ~20:31

P. S. Game exited with code 0, so there's nothing in crash-reports either.

henkelmax · Answer 28 · 2021-05-07T15:51:50.000Z

Does this happen with the latest version of the mod?
Which modloader are you using?

crash-ip21 · Answer 29 · 2021-05-07T16:08:05.000Z

Does this happen with the latest version of the mod?
Which modloader are you using?

Version 1.3.7 both on the server and client, Fabric.

henkelmax · Answer 30 · 2021-05-07T16:23:47.000Z

Do you use any of the aforementioned mods?

It will be hard to reproduce this issue, since the crash happens randomly and produces no logs...
Please let me know if you find out when exactly the crash happens.

crash-ip21 · Answer 31 · 2021-05-07T16:32:57.000Z

Do you use any of the aforementioned mods?

It will be hard to reproduce this issue, since the crash happens randomly and produces no logs...

Server uses carpet, lithium, hydrogen.

On client from mentioned mods are sodium and carpet as well.

If there's a way to talk to you privately, like in Discord dms, I could give you full list of mods both on server and client.

Please let me know if you find out when exactly the crash happens.

They kinda happen randomly, but I only noticed them happening in groups. My friend got crashes too, he's got sodium, but doesn't have carpet on his client.

henkelmax · Answer 32 · 2021-05-07T21:05:56.000Z

Yeah, it's fine, a friend of me got the crashes as well on Forge with completely different mods...

henkelmax · Answer 33 · 2021-05-12T09:05:44.000Z

It should be fixed with the latest version (1.3.10 with Fabric and 1.3.8 with Forge)

crash-ip21 · Answer 34 · 2021-05-12T09:05:46.000Z

@henkelmax thank you very much for fixing this bug this fast! We really like this mod with my friends and appreciate how fast you resolved the issue, even though it wasn't an obvious one!

henkelmax · Answer 35 · 2021-05-12T09:06:14.000Z

@henkelmax thank you very much for fixing this bug this fast! We really like this mod with my friends and appreciate how fast you resolved the issue, even though it wasn't an obvious one!

No problem :)
Let me know if it works for you.

crash-ip21 · Answer 36 · 2021-05-12T09:06:44.000Z

We will give it a test today!

Share to